Issue 392263002: Remove obsolete options in ScriptCompiler::CompileOptions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 392263002: Remove obsolete options in ScriptCompiler::CompileOptions. (Closed)

Created:
6 years, 5 months ago by vogelheim

Modified:
5 years, 6 months ago

Reviewers:
ulan, Yang

CC:
v8-dev, Paweł Hajdan Jr.

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

Remove obsolete options in ScriptCompiler::CompileOptions. This is a follow-on to https://code.google.com/p/v8/source/detail?r=22431 This will remove the compatibility logic, so that the API as described in r22431 is the only API. I'll let this CL will sit around for a while to give embedders a chance to update their code. R=yangguo@chromium.org, ulan@chromium.org BUG=chromium:399580 LOG=Y Committed: https://crrev.com/1d73a81ae0341a0d9c8d78c3fcf67bc2827d75d0 Cr-Commit-Position: refs/heads/master@{#29294}

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -15 lines)			Patch
M	include/v8.h	View	1	1 chunk	+1 line, -4 lines	0 comments	Download
M	src/api.cc	View	1	1 chunk	+0 lines, -9 lines	0 comments	Download
M	test/cctest/test-parsing.cc	View	1 2	2 chunks	+4 lines, -2 lines	0 comments	Download

Total messages: 6 (1 generated)

Yang

On 2014/07/17 08:37:39, Yang wrote: > LGTM. still LGTM btw :)

5 years, 6 months ago (2015-06-25 13:39:53 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/392263002/40001

5 years, 6 months ago (2015-06-25 14:02:01 UTC) #4

commit-bot: I haz the power

5 years, 6 months ago (2015-06-25 14:04:03 UTC) #6

Message was sent while issue was closed.

Patchset 3 (id:??) landed as
https://crrev.com/1d73a81ae0341a0d9c8d78c3fcf67bc2827d75d0
Cr-Commit-Position: refs/heads/master@{#29294}