Reimplement SetProperty using the LookupIterator

Reimplement SetProperty using the LookupIterator

BUG=
R=ishell@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=22482

[Toon Verwaest, 2014-07-16 12:39:47]

PTAL

[Igor Sheludko, 2014-07-18 13:08:32]

lgtm once comments are addressed:

https://codereview.chromium.org/392243002/diff/40001/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/392243002/diff/40001/src/objects.cc#newcode3044
src/objects.cc:3044: if (it->HolderIsReceiver() ||
&&

https://codereview.chromium.org/392243002/diff/40001/src/objects.cc#newcode3050
src/objects.cc:3050: // Fall through.
Wrong identation.

https://codereview.chromium.org/392243002/diff/40001/src/objects.cc#newcode3089
src/objects.cc:3089: bool is_observed = receiver->map()->is_observed();
Should we observe modifications of "hidden_string" field?

https://codereview.chromium.org/392243002/diff/40001/src/objects.cc#newcode3152
src/objects.cc:3152: if (receiver->map()->is_observed()) {
Same here.

https://codereview.chromium.org/392243002/diff/40001/src/v8natives.js
File src/v8natives.js (right):

https://codereview.chromium.org/392243002/diff/40001/src/v8natives.js#newcode...
src/v8natives.js:1326: %DebugPrint(name);
Spurious change?

[Toon Verwaest, 2014-07-18 13:45:22]

Addressed all comments except the one that was invalid. Landing.

https://codereview.chromium.org/392243002/diff/40001/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/392243002/diff/40001/src/objects.cc#newcode3044
src/objects.cc:3044: if (it->HolderIsReceiver() ||
The original was actually correct. If the holder-is-receiver, we also handle
DeclaredAccessInfos; but we don't if holder is not receiver; then we just handle
everything else.

On 2014/07/18 13:08:31, Igor Sheludko wrote:
> &&

[Toon Verwaest, 2014-07-18 13:47:36]

Committed patchset #2 manually as r22482 (presubmit successful).