Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(406)

Issue 392223004: Revert of Adding a router class to handle messages that expect responses. (Closed)

Created:
6 years, 5 months ago by johnme
Modified:
6 years, 5 months ago
Reviewers:
rmcilroy, qsr
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Project:
chromium
Visibility:
Public.

Description

Revert of Adding a router class to handle messages that expect responses. (https://codereview.chromium.org/371603003/) Reason for revert: This appears to have broken mojotest_instrumentation_tests with the errors like the ones listed below. http://build.chromium.org/p/chromium.webkit/builders/Android%20Tests%20%28dbg%29/builds/20270 C 52.086s Main [FAIL] org.chromium.mojo.bindings.ConnectorTest#testErrors: C 52.086s Main java.lang.NoClassDefFoundError: java.util.Objects C 52.086s Main at org.chromium.mojo.bindings.MessageHeader.equals(MessageHeader.java:189) C 52.086s Main at org.chromium.mojo.bindings.MessageWithHeader.<init>(MessageWithHeader.java:29) C 52.086s Main at org.chromium.mojo.bindings.MessageWithHeader.<init>(MessageWithHeader.java:39) C 52.086s Main at org.chromium.mojo.bindings.BindingsTestUtils.newRandomMessageWithHeader(BindingsTestUtils.java:85) C 52.086s Main at org.chromium.mojo.bindings.ConnectorTest.setUp(ConnectorTest.java:53) C 52.086s Main at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:191) C 52.086s Main at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:176) C 52.086s Main at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:554) C 52.086s Main at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1701) C 52.091s Main [CRASH] org.chromium.mojo.bindings.RouterTest#testReceivingViaRouterWithResponse: C 52.091s Main Native crash: Segmentation fault Original issue's description: > Adding a router class to handle messages that expect responses. > > This also introduce the notion of message header to allow routing. > > R=rmcilroy@chromium.org > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283767 TBR=qsr NOTREECHECKS=true NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284059

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+180 lines, -1149 lines) Patch
M build/android/lint/suppressions.xml View 1 chunk +0 lines, -4 lines 0 comments Download
M mojo/android/javatests/src/org/chromium/mojo/TestUtils.java View 2 chunks +0 lines, -2 lines 0 comments Download
M mojo/android/javatests/src/org/chromium/mojo/bindings/BindingsTestUtils.java View 2 chunks +7 lines, -44 lines 0 comments Download
M mojo/android/javatests/src/org/chromium/mojo/bindings/ConnectorTest.java View 5 chunks +8 lines, -7 lines 0 comments Download
D mojo/android/javatests/src/org/chromium/mojo/bindings/MessageHeaderTest.java View 1 chunk +0 lines, -69 lines 0 comments Download
A mojo/android/javatests/src/org/chromium/mojo/bindings/MessageTest.java View 1 chunk +110 lines, -0 lines 0 comments Download
D mojo/android/javatests/src/org/chromium/mojo/bindings/MessageWithHeaderTest.java View 1 chunk +0 lines, -109 lines 0 comments Download
D mojo/android/javatests/src/org/chromium/mojo/bindings/RouterTest.java View 1 chunk +0 lines, -134 lines 0 comments Download
D mojo/bindings/java/src/org/chromium/mojo/bindings/AutoCloseableRouter.java View 1 chunk +0 lines, -116 lines 0 comments Download
M mojo/bindings/java/src/org/chromium/mojo/bindings/BindingsHelper.java View 2 chunks +0 lines, -16 lines 0 comments Download
D mojo/bindings/java/src/org/chromium/mojo/bindings/ConnectionErrorHandler.java View 1 chunk +0 lines, -15 lines 0 comments Download
M mojo/bindings/java/src/org/chromium/mojo/bindings/Connector.java View 8 chunks +28 lines, -12 lines 0 comments Download
M mojo/bindings/java/src/org/chromium/mojo/bindings/Message.java View 2 chunks +24 lines, -0 lines 0 comments Download
D mojo/bindings/java/src/org/chromium/mojo/bindings/MessageHeader.java View 1 chunk +0 lines, -241 lines 0 comments Download
M mojo/bindings/java/src/org/chromium/mojo/bindings/MessageReceiver.java View 1 chunk +3 lines, -3 lines 0 comments Download
D mojo/bindings/java/src/org/chromium/mojo/bindings/MessageReceiverWithResponder.java View 1 chunk +0 lines, -21 lines 0 comments Download
D mojo/bindings/java/src/org/chromium/mojo/bindings/MessageWithHeader.java View 1 chunk +0 lines, -98 lines 0 comments Download
D mojo/bindings/java/src/org/chromium/mojo/bindings/Router.java View 1 chunk +0 lines, -37 lines 0 comments Download
D mojo/bindings/java/src/org/chromium/mojo/bindings/RouterImpl.java View 1 chunk +0 lines, -178 lines 0 comments Download
M mojo/bindings/java/src/org/chromium/mojo/bindings/Struct.java View 2 chunks +0 lines, -43 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
johnme
Created Revert of Adding a router class to handle messages that expect responses.
6 years, 5 months ago (2014-07-18 11:18:33 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/johnme@chromium.org/392223004/1
6 years, 5 months ago (2014-07-18 11:19:58 UTC) #2
Peter Beverloo
Best to only list one failure instead of all, it adds a lot of noise ...
6 years, 5 months ago (2014-07-18 11:19:59 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-18 11:19:59 UTC) #4
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 5 months ago (2014-07-18 11:20:00 UTC) #5
johnme
The CQ bit was unchecked by johnme@chromium.org
6 years, 5 months ago (2014-07-18 11:21:19 UTC) #6
johnme
The CQ bit was checked by johnme@chromium.org
6 years, 5 months ago (2014-07-18 11:22:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/johnme@chromium.org/392223004/1
6 years, 5 months ago (2014-07-18 11:24:00 UTC) #8
commit-bot: I haz the power
Change committed as 284059
6 years, 5 months ago (2014-07-18 11:25:20 UTC) #9
qsr
6 years, 5 months ago (2014-07-18 11:32:44 UTC) #10
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698