Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 392223003: Handle "frame-less" creation of Touch objects. (Closed)

Created:
6 years, 5 months ago by sof
Modified:
6 years, 5 months ago
Reviewers:
tkent, Rick Byers
CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, sof, eae+blinkwatch, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Handle "frame-less" creation of Touch objects. Should an empty LocalFrame be used, handle this gracefully. R= BUG=395032 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178444

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -1 line) Patch
M LayoutTests/fast/events/touch/document-create-touch-expected.txt View 1 chunk +14 lines, -0 lines 0 comments Download
M LayoutTests/fast/events/touch/script-tests/document-create-touch.js View 1 chunk +18 lines, -0 lines 0 comments Download
M Source/core/dom/Touch.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
sof
Please take a look.
6 years, 5 months ago (2014-07-18 10:29:58 UTC) #1
tkent
lgtm
6 years, 5 months ago (2014-07-18 13:45:14 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/392223003/1
6 years, 5 months ago (2014-07-18 13:46:16 UTC) #3
commit-bot: I haz the power
Change committed as 178444
6 years, 5 months ago (2014-07-18 14:50:46 UTC) #4
Rick Byers
6 years, 5 months ago (2014-07-18 17:44:27 UTC) #5
Message was sent while issue was closed.
On 2014/07/18 14:50:46, I haz the power (commit-bot) wrote:
> Change committed as 178444

Retroactive LGTM - thanks!

Powered by Google App Engine
This is Rietveld 408576698