Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Issue 392213002: Revert of Reland of [Blink] XMLTreeViewer should load resources from blink_resources.grd... (Closed)

Created:
6 years, 5 months ago by falken
Modified:
6 years, 5 months ago
CC:
abarth-chromium, blink-reviews, dglazkov+blink, jamesr
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Revert of Reland of [Blink] XMLTreeViewer should load resources from blink_resources.grd instead of relying upon xxd.py… (https://codereview.chromium.org/393213002/) Reason for revert: I mistakenly thought a clobber fixed the bot. It was actually the revert. The bot is failing again after the reland. Original patch: https://codereview.chromium.org/394003002/ Revert: https://codereview.chromium.org/397893002/ Reland: https://codereview.chromium.org/393213002 TBR=abarth@chromium.org,vivekg@chromium.org,vivek.vg@samsung.com NOTREECHECKS=true NOTRY=true BUG=312586, 394239 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178255

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M public/blink_resources.grd View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
falken
Created Revert of Revert of Revert of [Blink] XMLTreeViewer should load resources from blink_resources.grd instead ...
6 years, 5 months ago (2014-07-16 07:57:05 UTC) #1
falken
6 years, 5 months ago (2014-07-16 07:59:44 UTC) #2
falken
The CQ bit was checked by falken@chromium.org
6 years, 5 months ago (2014-07-16 07:59:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/falken@chromium.org/392213002/1
6 years, 5 months ago (2014-07-16 08:00:26 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-07-16 08:00:56 UTC) #5
Message was sent while issue was closed.
Change committed as 178255

Powered by Google App Engine
This is Rietveld 408576698