Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(739)

Issue 392193003: Revert of Update SourceBufferStream and its unit tests to always expect valid durations. (Closed)

Created:
6 years, 5 months ago by falken
Modified:
6 years, 5 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Update SourceBufferStream and its unit tests to always expect valid durations. (https://codereview.chromium.org/379693002/) Reason for revert: This seems to have broken several layout tests: event-attributes.html media-controller-time-clamp.html video-currentTime-delay.html video-currentTime-set.html video-duration-known-after-eos.html video-loop.html video-playbackrate.html video-played-collapse.html video-seek-past-end-paused.html video-seek-past-end-playing.html video-seek-to-duration-with-playbackrate-zero.html See for example this build: http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.6%20(dbg)/builds/16392 Original issue's description: > Update SourceBufferStream and its unit tests to always expect valid durations. > > This change fixes the SourceBufferStream unit tests so that they always > provide valid durations for buffers that it passes to SourceBufferStream. > I've also added code to SoureBufferStream to verify that it always gets > buffers with valid durations. > > Minor tweaks to test expectations were needed to compensate for the > SourceBufferStream behaving differently when it got actual durations instead > of using the durations it made up. In most cases I just used the duration > the SourceBufferStream was ultimately using. In a few cases the duration > the SourceBufferStream was generating didn't make any sense so I simply > changed the expectations to match the new behavior. > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283365 TBR=wolenetz@chromium.org,dalecurtis@chromium.org,acolwell@chromium.org NOTREECHECKS=true NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283390

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -113 lines) Patch
M media/base/decoder_buffer.h View 2 chunks +0 lines, -4 lines 0 comments Download
M media/base/stream_parser_buffer.cc View 2 chunks +0 lines, -7 lines 0 comments Download
M media/filters/source_buffer_stream.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M media/filters/source_buffer_stream_unittest.cc View 39 chunks +73 lines, -97 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
falken
Created Revert of Update SourceBufferStream and its unit tests to always expect valid durations.
6 years, 5 months ago (2014-07-16 08:55:13 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/falken@chromium.org/392193003/1
6 years, 5 months ago (2014-07-16 08:57:31 UTC) #2
commit-bot: I haz the power
6 years, 5 months ago (2014-07-16 08:59:30 UTC) #3
Message was sent while issue was closed.
Change committed as 283390

Powered by Google App Engine
This is Rietveld 408576698