Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(692)

Issue 392193002: Apply toFoo generation macro to TrackBase classes (Closed)

Created:
6 years, 5 months ago by gyuyoung-inactive
Modified:
6 years, 5 months ago
Reviewers:
haraken, philipj_slow
CC:
blink-reviews, blink-reviews-html_chromium.org, arv+blink, gasubic, fs, eric.carlson_apple.com, abarth-chromium, feature-media-reviews_chromium.org, dglazkov+blink, nessy, blink-reviews-bindings_chromium.org, vcarbune.chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Apply toFoo generation macro to TrackBase classes As a step to use toFoo, this cl introduces DEFINE_TRACK_TYPE_CASTS, and use it. BUG=309516 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178265

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -3 lines) Patch
M Source/bindings/core/v8/custom/V8TrackEventCustom.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/html/track/AudioTrack.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/html/track/TextTrack.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/html/track/TrackBase.h View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/html/track/VideoTrack.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
gyuyoung-inactive
Add haraken
6 years, 5 months ago (2014-07-16 06:33:57 UTC) #1
philipj_slow
LGTM for Source/core/
6 years, 5 months ago (2014-07-16 07:47:40 UTC) #2
haraken
LGTM
6 years, 5 months ago (2014-07-16 07:55:23 UTC) #3
gyuyoung-inactive
The CQ bit was checked by gyuyoung.kim@samsung.com
6 years, 5 months ago (2014-07-16 08:07:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/392193002/1
6 years, 5 months ago (2014-07-16 08:07:35 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 5 months ago (2014-07-16 09:23:08 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-16 10:24:41 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/17231)
6 years, 5 months ago (2014-07-16 10:24:42 UTC) #8
gyuyoung-inactive
The CQ bit was checked by gyuyoung.kim@samsung.com
6 years, 5 months ago (2014-07-16 11:00:05 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/392193002/1
6 years, 5 months ago (2014-07-16 11:00:41 UTC) #10
commit-bot: I haz the power
6 years, 5 months ago (2014-07-16 11:29:49 UTC) #11
Message was sent while issue was closed.
Change committed as 178265

Powered by Google App Engine
This is Rietveld 408576698