Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 392163003: Fix PagedSpace size accounting. (Closed)

Created:
6 years, 5 months ago by Yang
Modified:
6 years, 5 months ago
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Add TODO #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M src/mark-compact.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M src/spaces.h View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Yang
6 years, 5 months ago (2014-07-16 11:59:42 UTC) #1
Hannes Payer (out of office)
The accounting is still not correct. For example static intptr_t Free(PagedSpace* space, FreeList* free_list, Address ...
6 years, 5 months ago (2014-07-16 12:09:19 UTC) #2
Yang
On 2014/07/16 12:09:19, Hannes Payer wrote: > The accounting is still not correct. For example ...
6 years, 5 months ago (2014-07-16 12:18:09 UTC) #3
Yang
On 2014/07/16 12:18:09, Yang wrote: > On 2014/07/16 12:09:19, Hannes Payer wrote: > > The ...
6 years, 5 months ago (2014-07-16 13:03:47 UTC) #4
Hannes Payer (out of office)
lgtm, please fix the TODO https://codereview.chromium.org/392163003/diff/20001/src/mark-compact.cc File src/mark-compact.cc (right): https://codereview.chromium.org/392163003/diff/20001/src/mark-compact.cc#newcode3950 src/mark-compact.cc:3950: // TODO(hpayer) account for ...
6 years, 5 months ago (2014-07-16 13:34:06 UTC) #5
Yang
https://codereview.chromium.org/392163003/diff/20001/src/mark-compact.cc File src/mark-compact.cc (right): https://codereview.chromium.org/392163003/diff/20001/src/mark-compact.cc#newcode3950 src/mark-compact.cc:3950: // TODO(hpayer) account for wasted bytes in concurrent sweeping ...
6 years, 5 months ago (2014-07-16 13:36:16 UTC) #6
Yang
6 years, 5 months ago (2014-07-16 13:37:06 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 manually as r22433 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698