Remove X11/Xlib.h include from selection_requestor.h

Remove X11/Xlib.h include from selection_requestor.h

Removing the include of Xlib.h makes selection_requestor.h more easily
testable. In particular, the definition of None in X.h conflicts with
that in gtest-type-util.h

This CL also adds XAtom to x11_types.h so that it does not need to be forward declared everywhere.

BUG=None
TEST=None
R=derat,danakj
TBR=dcheng (for trivial change to clipboard_aurax11.cc)

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283740

[pkotwicz, 2014-07-16 02:54:18]

derat@ PTAL.

I am including the new test as part of
https://codereview.chromium.org/391593002/ which I rewrote. More comments as to
why I rewrote that CL there.

[Daniel Erat, 2014-07-16 03:03:13]

thanks, i'm glad to see all those ::s go away

https://codereview.chromium.org/392153002/diff/1/ui/base/x/selection_requestor.h
File ui/base/x/selection_requestor.h (right):

https://codereview.chromium.org/392153002/diff/1/ui/base/x/selection_requesto...
ui/base/x/selection_requestor.h:25: typedef struct _XDisplay XDisplay;
can you include ui/gfx/x/x11_types.h instead (and add Atom to it if needed,
perhaps renamed to XAtom)?

[pkotwicz, 2014-07-16 14:55:31]

derat@, can you please take another look?

[Daniel Erat, 2014-07-16 15:20:04]

lgtm

[pkotwicz, 2014-07-16 15:25:25]

danakj@ for ui/gfx/ OWNERS

[danakj, 2014-07-16 15:27:34]

rsLGTM

[pkotwicz, 2014-07-16 16:46:19]

The CQ bit was checked by pkotwicz@chromium.org

[pkotwicz, 2014-07-16 16:46:26]

The CQ bit was unchecked by pkotwicz@chromium.org

[pkotwicz, 2014-07-16 16:47:23]

The CQ bit was checked by pkotwicz@chromium.org

[commit-bot: I haz the power, 2014-07-16 16:48:32]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/392153002/20001

[commit-bot: I haz the power, 2014-07-16 20:50:44]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-07-17 10:55:24]

Change committed as 283740