Issue 392133002: Remove Layout code from ContentsSwitcherView.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 392133002: Remove Layout code from ContentsSwitcherView. (Closed)

Created:
6 years, 5 months ago by calamity

Modified:
6 years, 5 months ago

Reviewers:
Matt Giuca

CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina

Base URL:
https://chromium.googlesource.com/chromium/src.git@land_return_to_page

Visibility:
Public.

More Reviews

Description

Remove Layout code from ContentsSwitcherView. This CL cleans up ContentsSwitcherView by removing its custom layout code which is superceded by BoxLayout's main axis alignment. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283495

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -28 lines)			Patch
	M	ui/app_list/views/contents_switcher_view.h	View		2 chunks	+1 line, -5 lines	0 comments	Download
	M	ui/app_list/views/contents_switcher_view.cc	View		2 chunks	+6 lines, -23 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/calamity@chromium.org/392133002/1

6 years, 5 months ago (2014-07-16 02:56:58 UTC) #5

Message was sent while issue was closed.

Change committed as 283495

Expand Messages | Collapse Messages