Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 392113002: [android_webview] Support null AwWebResourceResponse headers. (Closed)

Created:
6 years, 5 months ago by mkosiba (inactive)
Modified:
6 years, 4 months ago
CC:
chromium-reviews, android-webview-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

[android_webview] Support null AwWebResourceResponse headers. We shouldn't crash when the response headers map is null. BUG=394173 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285517

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Total comments: 2

Patch Set 5 : use equals instead of == #

Total comments: 2

Patch Set 6 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -7 lines) Patch
M android_webview/java/src/org/chromium/android_webview/AwWebResourceResponse.java View 1 1 chunk +9 lines, -7 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientShouldInterceptRequestTest.java View 1 2 3 4 2 chunks +17 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
mkosiba (inactive)
6 years, 5 months ago (2014-07-16 17:40:07 UTC) #1
benm (inactive)
https://codereview.chromium.org/392113002/diff/60001/android_webview/java/src/org/chromium/android_webview/AwWebResourceResponse.java File android_webview/java/src/org/chromium/android_webview/AwWebResourceResponse.java (right): https://codereview.chromium.org/392113002/diff/60001/android_webview/java/src/org/chromium/android_webview/AwWebResourceResponse.java#newcode78 android_webview/java/src/org/chromium/android_webview/AwWebResourceResponse.java:78: return mResponseHeaderNames; the native code will handle this returning ...
6 years, 5 months ago (2014-07-20 16:11:23 UTC) #2
mkosiba (inactive)
https://codereview.chromium.org/392113002/diff/60001/android_webview/java/src/org/chromium/android_webview/AwWebResourceResponse.java File android_webview/java/src/org/chromium/android_webview/AwWebResourceResponse.java (right): https://codereview.chromium.org/392113002/diff/60001/android_webview/java/src/org/chromium/android_webview/AwWebResourceResponse.java#newcode78 android_webview/java/src/org/chromium/android_webview/AwWebResourceResponse.java:78: return mResponseHeaderNames; On 2014/07/20 16:11:23, benm wrote: > the ...
6 years, 5 months ago (2014-07-22 11:08:45 UTC) #3
benm (inactive)
https://codereview.chromium.org/392113002/diff/80001/build/android/pylib/base/base_test_runner.py File build/android/pylib/base/base_test_runner.py (right): https://codereview.chromium.org/392113002/diff/80001/build/android/pylib/base/base_test_runner.py#newcode152 build/android/pylib/base/base_test_runner.py:152: return is this right?
6 years, 5 months ago (2014-07-23 01:09:40 UTC) #4
mkosiba (inactive)
https://codereview.chromium.org/392113002/diff/80001/build/android/pylib/base/base_test_runner.py File build/android/pylib/base/base_test_runner.py (right): https://codereview.chromium.org/392113002/diff/80001/build/android/pylib/base/base_test_runner.py#newcode152 build/android/pylib/base/base_test_runner.py:152: return On 2014/07/23 01:09:40, benm wrote: > is this ...
6 years, 4 months ago (2014-07-24 16:08:28 UTC) #5
benm (inactive)
lgtm
6 years, 4 months ago (2014-07-24 19:04:07 UTC) #6
__use chromium account please
The CQ bit was checked by mkosiba@google.com
6 years, 4 months ago (2014-07-25 06:15:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkosiba@chromium.org/392113002/100001
6 years, 4 months ago (2014-07-25 06:17:41 UTC) #8
commit-bot: I haz the power
6 years, 4 months ago (2014-07-25 07:13:42 UTC) #9
Message was sent while issue was closed. 
Change committed as 285517

Powered by Google App Engine
This is Rietveld 408576698