Issue 392063002: Mojo: Add a test for nested RunLoop::Run()

Issue 392063002: Mojo: Add a test for nested RunLoop::Run() (Closed)

Created:
6 years, 5 months ago by Hajime Morrita

Modified:
6 years, 5 months ago

Reviewers:
darin (slow to review), sky, viettrungluu

CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Mojo: Add a test for nested RunLoop::Run() BUG=384633 R=sky@chromium.org, darin@chromium.org, viettrungluu@chromium.org TEST=RunLoopTest.NestedRun Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283382

Patch Set 1 #

Total comments: 1

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+94 lines, -1 line)			Patch
	M	mojo/public/cpp/utility/tests/run_loop_unittest.cc	View		1 chunk	+94 lines, -1 line	1 comment	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/morrita@chromium.org/392063002/1

6 years, 5 months ago (2014-07-16 00:23:35 UTC) #5

viettrungluu

LGTM too w/nit. Feel free to take care of the whitespace issue separately, and not ...

6 years, 5 months ago (2014-07-16 02:46:08 UTC) #6

Hajime Morrita

6 years, 5 months ago (2014-07-16 17:10:11 UTC) #8

Message was sent while issue was closed.

On 2014/07/16 02:46:08, viettrungluu wrote:
> LGTM too w/nit. Feel free to take care of the whitespace issue separately, and
> not interrupt the CQ. :)
> 
>
https://codereview.chromium.org/392063002/diff/1/mojo/public/cpp/utility/test...
> File mojo/public/cpp/utility/tests/run_loop_unittest.cc (right):
> 
>
https://codereview.chromium.org/392063002/diff/1/mojo/public/cpp/utility/test...
> mojo/public/cpp/utility/tests/run_loop_unittest.cc:193: 
> nit: Remove extra blank line.

Thanks. Landing it at https://codereview.chromium.org/397063002/

Expand Messages | Collapse Messages