Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 392053002: Add experiment IDs for new NTP on Android M36+. (Closed)

Created:
6 years, 5 months ago by newt (away)
Modified:
6 years, 5 months ago
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Add experiment IDs for new NTP on Android M36+. This also fixes the naming of several existing IDs. BUG=365411 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283739

Patch Set 1 #

Patch Set 2 : added separate IDs for beta channel #

Total comments: 1

Patch Set 3 : add space before = #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M chrome/common/variations/variation_ids.h View 1 2 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
newt (away)
PTAL
6 years, 5 months ago (2014-07-15 22:49:29 UTC) #1
Alexei Svitkine (slow)
lgtm
6 years, 5 months ago (2014-07-15 22:56:30 UTC) #2
newt (away)
The CQ bit was checked by newt@chromium.org
6 years, 5 months ago (2014-07-15 23:32:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/newt@chromium.org/392053002/1
6 years, 5 months ago (2014-07-15 23:33:51 UTC) #4
newt (away)
PTAL After talking to tyan@ who's going to look at metrics, I added separate IDs ...
6 years, 5 months ago (2014-07-16 00:10:05 UTC) #5
Alexei Svitkine (slow)
lgtm https://codereview.chromium.org/392053002/diff/20001/chrome/common/variations/variation_ids.h File chrome/common/variations/variation_ids.h (right): https://codereview.chromium.org/392053002/diff/20001/chrome/common/variations/variation_ids.h#newcode250 chrome/common/variations/variation_ids.h:250: ANDROID_STABLE_TABLET_NATIVE_NTP_TWO_URL_BARS= 3311932, Nit: Space before =
6 years, 5 months ago (2014-07-16 13:09:27 UTC) #6
newt (away)
The CQ bit was checked by newt@chromium.org
6 years, 5 months ago (2014-07-16 18:52:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/newt@chromium.org/392053002/40001
6 years, 5 months ago (2014-07-16 18:57:32 UTC) #8
commit-bot: I haz the power
6 years, 5 months ago (2014-07-17 10:53:51 UTC) #9
Message was sent while issue was closed. 
Change committed as 283739

Powered by Google App Engine
This is Rietveld 408576698