runtime/vm/snapshot.cc - Issue 392043003: The dart version of typeddata library has changed to be compatible with the dart2js implementation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/snapshot.cc

Issue 392043003: The dart version of typeddata library has changed to be compatible with the dart2js implementation (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/snapshot.cc

===================================================================

--- runtime/vm/snapshot.cc (revision 38259)

+++ runtime/vm/snapshot.cc (working copy)

@@ -56,7 +56,8 @@

static intptr_t ObjectIdFromClassId(intptr_t class_id) {

ASSERT((class_id > kIllegalCid) && (class_id < kNumPredefinedCids));

- ASSERT(!RawObject::IsTypedDataViewClassId(class_id));

+ ASSERT(!(RawObject::IsTypedDataViewClassId(class_id) ||

+ (class_id == kByteBufferCid)));

Cutch 2014/07/16 21:34:33 Maybe factor these "== kByteBufferCid" into a stat

siva 2014/07/17 21:36:55 Done.

return (class_id + kClassIdsOffset);

}

@@ -1082,7 +1083,8 @@

return;

}

- if (RawObject::IsTypedDataViewClassId(class_id)) {

+ if (RawObject::IsTypedDataViewClassId(class_id) ||

+ (class_id == kByteBufferCid)) {

Cutch 2014/07/16 21:34:33 Maybe factor these "== kByteBufferCid" into a stat

siva 2014/07/17 21:36:55 Done.

WriteInstanceRef(raw, cls);

return;

}

« no previous file with comments | « runtime/vm/raw_object.cc ('k') | runtime/vm/symbols.h » ('j') | no next file with comments »