Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(581)

Unified Diff: chrome_frame/urlmon_upload_data_stream.cc

Issue 39203004: [Net] Fix error handling on wrong file in UploadData (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome_frame/urlmon_upload_data_stream.h ('k') | net/base/upload_file_element_reader.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome_frame/urlmon_upload_data_stream.cc
diff --git a/chrome_frame/urlmon_upload_data_stream.cc b/chrome_frame/urlmon_upload_data_stream.cc
index f825f3f87c317a4b14ae396225b96f5a9b8837ed..2fe2ed0b71f0d1a26ecbb7380d6b628f330055a3 100644
--- a/chrome_frame/urlmon_upload_data_stream.cc
+++ b/chrome_frame/urlmon_upload_data_stream.cc
@@ -59,11 +59,10 @@ net::UploadDataStream* CreateUploadDataStream(net::UploadData* upload_data) {
} // namespace
-void UrlmonUploadDataStream::Initialize(net::UploadData* upload_data) {
+bool UrlmonUploadDataStream::Initialize(net::UploadData* upload_data) {
upload_data_ = upload_data;
request_body_stream_.reset(CreateUploadDataStream(upload_data));
- const int result = request_body_stream_->Init(net::CompletionCallback());
- DCHECK_EQ(net::OK, result);
+ return request_body_stream_->Init(net::CompletionCallback()) == net::OK;
}
STDMETHODIMP UrlmonUploadDataStream::Read(void* pv, ULONG cb, ULONG* read) {
« no previous file with comments | « chrome_frame/urlmon_upload_data_stream.h ('k') | net/base/upload_file_element_reader.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698