Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7925)

Unified Diff: chrome_frame/plugin_url_request.cc

Issue 39203004: [Net] Fix error handling on wrong file in UploadData (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: expectation fix Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome_frame/plugin_url_request.cc
diff --git a/chrome_frame/plugin_url_request.cc b/chrome_frame/plugin_url_request.cc
index cfc798b712556074e4dffb45319ad62d52610b03..fb199d8d3eb823e35b63064c55896c2d39527506 100644
--- a/chrome_frame/plugin_url_request.cc
+++ b/chrome_frame/plugin_url_request.cc
@@ -44,7 +44,11 @@ bool PluginUrlRequest::Initialize(PluginUrlRequestDelegate* delegate,
NOTREACHED();
} else {
upload_stream->AddRef();
- upload_stream->Initialize(upload_data);
+ if (!upload_stream->Initialize(upload_data)) {
+ upload_stream->Release();
+ return true;
hashimoto 2013/11/08 04:59:08 Is it OK to return without setting enable_frame_bu
tzik 2013/11/11 04:03:04 Done.
+ }
+
upload_data_.Attach(upload_stream);
is_chunked_upload_ = upload_data->is_chunked();
STATSTG stat;

Powered by Google App Engine
This is Rietveld 408576698