[Net] Fix error handling on wrong file in UploadData

chrome_frame/plugin_url_request.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome_frame/plugin_url_request.h"
 
 #include "chrome/common/automation_messages.h"
 
 PluginUrlRequest::PluginUrlRequest()
     : delegate_(NULL),
@@ skipping 26 matching lines @@
     // We store a pointer to UrlmonUploadDataStream and not net::UploadData
     // since UrlmonUploadDataStream implements thread safe ref counting and
     // UploadData does not.
     CComObject<UrlmonUploadDataStream>* upload_stream = NULL;
     HRESULT hr = CComObject<UrlmonUploadDataStream>::CreateInstance(
         &upload_stream);
     if (FAILED(hr)) {
       NOTREACHED();
     } else {
       upload_stream->AddRef();
-      upload_stream->Initialize(upload_data);
+      if (!upload_stream->Initialize(upload_data)) {
+        upload_stream->Release();
+        enable_frame_busting_ = enable_frame_busting;

[hashimoto, 2013/11/11 04:27:53]

Can't lines 49 & 61 moved to above, to avoid code duplication?

[tzik, 2013/11/11 05:33:52]

Done.

+        return true;
+      }
+
       upload_data_.Attach(upload_stream);
       is_chunked_upload_ = upload_data->is_chunked();
       STATSTG stat;
       upload_stream->Stat(&stat, STATFLAG_NONAME);
       post_data_len_ = stat.cbSize.QuadPart;
     }
   }
 
   enable_frame_busting_ = enable_frame_busting;
 
   return true;
 }