IdentityAPI: update SigninGlobalError when tokens become available

IdentityAPI: update SigninGlobalError when tokens become available

AccountTracker now kicks SigninGlobalError whenever it gets a new
token. Otherwise the error state may continue to reflect an error
that is no longer active.

BUG=310935
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=230967

[fgorski, 2013-10-24 17:17:33]

lgtm with a comment. Please take a look.

https://codereview.chromium.org/39203002/diff/1/chrome/browser/extensions/api...
File chrome/browser/extensions/api/identity/account_tracker.cc (right):

https://codereview.chromium.org/39203002/diff/1/chrome/browser/extensions/api...
chrome/browser/extensions/api/identity/account_tracker.cc:133:
account_errors_.erase(account_key);
Will it not be needed here as well?

[Michael Courage, 2013-10-24 18:23:37]

really always update SigninGlobalError

[Michael Courage, 2013-10-24 18:28:20]

https://codereview.chromium.org/39203002/diff/1/chrome/browser/extensions/api...
File chrome/browser/extensions/api/identity/account_tracker.cc (right):

https://codereview.chromium.org/39203002/diff/1/chrome/browser/extensions/api...
chrome/browser/extensions/api/identity/account_tracker.cc:133:
account_errors_.erase(account_key);
On 2013/10/24 17:17:33, Filip Gorski wrote:
> Will it not be needed here as well?

facepalm

[fgorski, 2013-10-24 18:43:48]

still lgtm :)

[commit-bot: I haz the power, 2013-10-24 20:20:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/courage@chromium.org/39203002/60001

[commit-bot: I haz the power, 2013-10-25 00:31:24]

Retried try job too often on win7_aura for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&...

[commit-bot: I haz the power, 2013-10-25 04:51:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/courage@chromium.org/39203002/60001

[commit-bot: I haz the power, 2013-10-25 06:38:53]

Change committed as 230967