Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Unified Diff: chrome/test/nacl/nacl_browsertest_util.cc

Issue 392023002: Remove disable-pnacl flag. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/nacl/nacl_browsertest_util.cc
diff --git a/chrome/test/nacl/nacl_browsertest_util.cc b/chrome/test/nacl/nacl_browsertest_util.cc
index 9c1d57d8ac736a083dc52059cbb46575787a8b53..1d67051d9a42007242f008707a072621551ec64a 100644
--- a/chrome/test/nacl/nacl_browsertest_util.cc
+++ b/chrome/test/nacl/nacl_browsertest_util.cc
@@ -224,10 +224,6 @@ bool NaClBrowserTestBase::IsAPnaclTest() {
return false;
}
-bool NaClBrowserTestBase::IsPnaclDisabled() {
- return false;
-}
-
GURL NaClBrowserTestBase::TestURL(
const base::FilePath::StringType& url_fragment) {
base::FilePath expanded_url = base::FilePath(FILE_PATH_LITERAL("files"));
@@ -253,9 +249,6 @@ void NaClBrowserTestBase::RunLoadTest(
AddPnaclParm(test_file, &test_file_with_pnacl);
}
base::FilePath::StringType test_file_with_both = test_file_with_pnacl;
- if (IsPnaclDisabled()) {
- AddPnaclDisabledParm(test_file_with_pnacl, &test_file_with_both);
- }
bool ok = RunJavascriptTest(TestURL(test_file_with_both), &handler);
ASSERT_TRUE(ok) << handler.error_message();
ASSERT_TRUE(handler.test_passed()) << "Test failed.";
@@ -269,9 +262,6 @@ void NaClBrowserTestBase::RunNaClIntegrationTest(
AddPnaclParm(url_fragment, &url_fragment_with_pnacl);
}
base::FilePath::StringType url_fragment_with_both = url_fragment_with_pnacl;
- if (IsPnaclDisabled()) {
- AddPnaclDisabledParm(url_fragment_with_pnacl, &url_fragment_with_both);
- }
bool ok = RunJavascriptTest(full_url
? GURL(url_fragment_with_both)
: TestURL(url_fragment_with_both),
@@ -312,19 +302,6 @@ base::FilePath::StringType NaClBrowserTestPnaclDisabled::Variant() {
return FILE_PATH_LITERAL("pnacl");
}
-bool NaClBrowserTestPnaclDisabled::IsAPnaclTest() {
- return true;
-}
-
-bool NaClBrowserTestPnaclDisabled::IsPnaclDisabled() {
- return true;
-}
-void NaClBrowserTestPnaclDisabled::SetUpCommandLine(
- base::CommandLine* command_line) {
- NaClBrowserTestBase::SetUpCommandLine(command_line);
- command_line->AppendSwitch(switches::kDisablePnacl);
-}
-
base::FilePath::StringType NaClBrowserTestNonSfiMode::Variant() {
return FILE_PATH_LITERAL("libc-free");
}
« chrome/renderer/chrome_content_renderer_client.cc ('K') | « chrome/test/nacl/nacl_browsertest_util.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698