Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(486)

Unified Diff: Source/core/css/parser/CSSPropertyParser.cpp

Issue 392013002: Cleanup SVG color parsing handling (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Add alpha change Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/css/parser/CSSPropertyParser.cpp
diff --git a/Source/core/css/parser/CSSPropertyParser.cpp b/Source/core/css/parser/CSSPropertyParser.cpp
index b9e8026f6d071f3313b716ff9d9194c559dad950..f29b85b2ddbc641d8d2b7cc072439f8b1c0cf5dc 100644
--- a/Source/core/css/parser/CSSPropertyParser.cpp
+++ b/Source/core/css/parser/CSSPropertyParser.cpp
@@ -8315,18 +8315,12 @@ bool CSSPropertyParser::parseSVGValue(CSSPropertyID propId, bool important)
case CSSPropertyStopColor: // TODO : icccolor
case CSSPropertyFloodColor:
case CSSPropertyLightingColor:
- if (isSystemColor(id)) {
+ if (isSystemColor(id))
parsedValue = cssValuePool().createColorValue(RenderTheme::theme().systemColor(id).rgb());
- } else if ((id >= CSSValueAqua && id <= CSSValueTransparent)
- || (id >= CSSValueAliceblue && id <= CSSValueYellowgreen) || id == CSSValueGrey) {
- StyleColor styleColor = BisonCSSParser::colorFromRGBColorString(value->string);
- ASSERT(!styleColor.isCurrentColor());
- parsedValue = cssValuePool().createColorValue(styleColor.color().rgb());
- } else if (id == CSSValueCurrentcolor) {
+ else if (id == CSSValueCurrentcolor)
parsedValue = cssValuePool().createIdentifierValue(id);
- } else { // TODO : svgcolor (iccColor)
+ else // TODO : svgcolor (iccColor)
parsedValue = parseColor();
- }
if (parsedValue)
m_valueList->next();
« Source/core/css/SVGCSSValueKeywords.in ('K') | « Source/core/css/SVGCSSValueKeywords.in ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698