Cleanup SVG color parsing handling

Cleanup SVG color parsing handling

Cleanup SVG color parsing handling, for stop-color, lighting-color and flood-color there is no need to test explicitly for
SVG extended colors, parseColor() can handle it. I was triggered by 'alpha' being placed within the SVG CSS extended color keywords, potentially leading to bugs, so move it out.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178309

[rwlbuis, 2014-07-15 22:49:10]

PTAL

[fs, 2014-07-16 07:34:10]

LGTM w/ the below addressed in some way. Might want to wait for krit to chime
in.

https://codereview.chromium.org/392013002/diff/20001/Source/core/css/SVGCSSVa...
File Source/core/css/SVGCSSValueKeywords.in (left):

https://codereview.chromium.org/392013002/diff/20001/Source/core/css/SVGCSSVa...
Source/core/css/SVGCSSValueKeywords.in:8: alpha
Looks like 'luminance' is a similar "mistake". Not sure what these are doing in
this file, but maybe krit does? (They are obviously related to some mask
property [mask-source-type?], but...)

[rwlbuis, 2014-07-16 13:15:29]

On 2014/07/16 07:34:10, fs wrote:
> LGTM w/ the below addressed in some way. Might want to wait for krit to chime
> in.
> 
>
https://codereview.chromium.org/392013002/diff/20001/Source/core/css/SVGCSSVa...
> File Source/core/css/SVGCSSValueKeywords.in (left):
> 
>
https://codereview.chromium.org/392013002/diff/20001/Source/core/css/SVGCSSVa...
> Source/core/css/SVGCSSValueKeywords.in:8: alpha
> Looks like 'luminance' is a similar "mistake". Not sure what these are doing
in
> this file, but maybe krit does? (They are obviously related to some mask
> property [mask-source-type?], but...)

Well spotted! It seems to be there because of sorting rules, like alpha. I also
wonder if these two mask related properties are really SVG specific.

[krit, 2014-07-16 18:03:30]

lgtm

[commit-bot: I haz the power, 2014-07-16 18:04:43]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/rob.buis@samsung.com/392013002/40001

[rwlbuis, 2014-07-16 20:28:20]

The CQ bit was unchecked by rob.buis@samsung.com

[rwlbuis, 2014-07-16 20:28:23]

The CQ bit was checked by rob.buis@samsung.com

[commit-bot: I haz the power, 2014-07-16 20:28:46]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/rob.buis@samsung.com/392013002/40001

[commit-bot: I haz the power, 2014-07-17 03:34:42]

Change committed as 178309