Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5263)

Unified Diff: chrome/browser/gtk/download_shelf_gtk.cc

Issue 392007: gtk: Hide the status bubble when the mouse nears it. (Closed)
Patch Set: merge again Created 11 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/cocoa/status_bubble_mac.mm ('k') | chrome/browser/gtk/rounded_window.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/gtk/download_shelf_gtk.cc
diff --git a/chrome/browser/gtk/download_shelf_gtk.cc b/chrome/browser/gtk/download_shelf_gtk.cc
index 336454fb05e95ebc4b75b5873b59c57cc1f33535..1e138921e2ffdd8bc0ddb5e87dfbd1dfe51fa1a8 100644
--- a/chrome/browser/gtk/download_shelf_gtk.cc
+++ b/chrome/browser/gtk/download_shelf_gtk.cc
@@ -127,7 +127,7 @@ DownloadShelfGtk::DownloadShelfGtk(Browser* browser, GtkWidget* parent)
FALSE, FALSE, 0);
// Make sure we are at the very end.
gtk_box_reorder_child(GTK_BOX(parent), slide_widget_->widget(), 0);
- slide_widget_->Open();
+ Show();
}
DownloadShelfGtk::~DownloadShelfGtk() {
@@ -155,6 +155,7 @@ bool DownloadShelfGtk::IsClosing() const {
void DownloadShelfGtk::Show() {
slide_widget_->Open();
+ browser_->UpdateDownloadShelfVisibility(true);
}
void DownloadShelfGtk::Close() {
@@ -162,8 +163,6 @@ void DownloadShelfGtk::Close() {
// we are on top.
gdk_window_raise(shelf_.get()->window);
slide_widget_->Close();
-
- // TODO(estade): Remove. The status bubble should query its window instead.
browser_->UpdateDownloadShelfVisibility(false);
}
@@ -224,8 +223,6 @@ void DownloadShelfGtk::RemoveDownloadItem(DownloadItemGtk* download_item) {
delete download_item;
if (download_items_.empty()) {
slide_widget_->CloseWithoutAnimation();
-
- // TODO(estade): Remove. The status bubble should query its window instead.
browser_->UpdateDownloadShelfVisibility(false);
}
}
« no previous file with comments | « chrome/browser/cocoa/status_bubble_mac.mm ('k') | chrome/browser/gtk/rounded_window.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698