Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Issue 391963002: [Blink] XMLTreeViewer should load resources from blink_resources.grd instead of relying upon xxd.py (Closed)

Created:
6 years, 5 months ago by vivekg_samsung
Modified:
6 years, 5 months ago
CC:
abarth-chromium, blink-reviews, dglazkov+blink, jamesr, jochen (gone - plz use gerrit)
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

[Blink] XMLTreeViewer should load resources from blink_resources.grd instead of relying upon xxd.py (Part-2) Blink should make use of blink_resources.grd for the inline resources for displaying XML tree view. This removes the dependency upon using xxd.py which embeds the resources as strings. BUG=312586 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178522

Patch Set 1 #

Patch Set 2 : Patch for landing! #

Patch Set 3 : Patch for landing after rebase! #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -265 lines) Patch
Source/bindings/core/v8/ScriptDebugServer.cpp View 2 chunks +4 lines, -2 lines 0 comments Download
Source/build/ConvertFileToHeaderWithCharacterArray.gypi View 1 chunk +0 lines, -63 lines 0 comments Download
Source/build/scripts/xxd.py View 1 chunk +0 lines, -50 lines 0 comments Download
M Source/core/BUILD.gn View 5 chunks +0 lines, -56 lines 0 comments Download
Source/core/core.gyp View 3 chunks +0 lines, -52 lines 0 comments Download
M Source/core/core_generated.gyp View 1 chunk +0 lines, -32 lines 0 comments Download
Source/core/inspector/InjectedScriptCanvasModule.cpp View 2 chunks +4 lines, -2 lines 0 comments Download
Source/core/inspector/InjectedScriptManager.cpp View 2 chunks +4 lines, -2 lines 0 comments Download
Source/core/inspector/InspectorOverlay.cpp View 3 chunks +4 lines, -2 lines 0 comments Download
M Source/core/xml/XMLTreeViewer.cpp View 2 chunks +8 lines, -4 lines 0 comments Download
public/blink_resources.grd View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (0 generated)
vivekg
Chromium side changes https://codereview.chromium.org/395833002/ PTAL, thank you!
6 years, 5 months ago (2014-07-15 12:18:00 UTC) #1
vivekg
We should break this change into three parts so as not to break the builds ...
6 years, 5 months ago (2014-07-15 14:09:20 UTC) #2
eseidel
I don't know a whole lot about this subsystem of Chromium. This appears to be ...
6 years, 5 months ago (2014-07-15 15:34:48 UTC) #3
abarth-chromium
LGTM
6 years, 5 months ago (2014-07-15 19:44:13 UTC) #4
abarth-chromium
@eseidel: Yeah, we're moving these resources from being hard-coded in the binary to being in ...
6 years, 5 months ago (2014-07-15 19:44:37 UTC) #5
vivekg
The CQ bit was checked by vivekg@chromium.org
6 years, 5 months ago (2014-07-19 12:09:53 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vivek.vg@samsung.com/391963002/20001
6 years, 5 months ago (2014-07-19 12:10:17 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_blink_compile_dbg on tryserver.blink ...
6 years, 5 months ago (2014-07-19 12:56:07 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-19 12:57:21 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/30735)
6 years, 5 months ago (2014-07-19 12:57:22 UTC) #10
vivekg
The CQ bit was checked by vivekg@chromium.org
6 years, 5 months ago (2014-07-19 18:18:46 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vivek.vg@samsung.com/391963002/40001
6 years, 5 months ago (2014-07-19 18:19:24 UTC) #12
vivekg
The CQ bit was checked by vivekg@chromium.org
6 years, 5 months ago (2014-07-19 18:28:22 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vivek.vg@samsung.com/391963002/60001
6 years, 5 months ago (2014-07-19 18:28:28 UTC) #14
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 5 months ago (2014-07-19 19:32:55 UTC) #15
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-19 20:41:12 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_dbg on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/17274)
6 years, 5 months ago (2014-07-19 20:41:13 UTC) #17
vivekg
The CQ bit was checked by vivekg@chromium.org
6 years, 5 months ago (2014-07-20 01:48:28 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vivek.vg@samsung.com/391963002/80001
6 years, 5 months ago (2014-07-20 01:48:40 UTC) #19
commit-bot: I haz the power
6 years, 5 months ago (2014-07-20 02:44:07 UTC) #20
Message was sent while issue was closed.
Change committed as 178522

Powered by Google App Engine
This is Rietveld 408576698