Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issue 391933002: X87: Use the same registers for StoreIC and KeyedStoreIC. (Closed)

Created:
6 years, 5 months ago by chunyang.dai
Modified:
6 years, 5 months ago
Reviewers:
Weiliang, mvstanton
CC:
v8-dev, danno
Base URL:
https://chromium.googlesource.com/external/v8.git@bleeding_edge
Project:
v8
Visibility:
Public.

Description

X87: Use the same registers for StoreIC and KeyedStoreIC. port r22387 original commit message: Use the same registers for StoreIC and KeyedStoreIC. Based on https://codereview.chromium.org/389283002 ("Use register parameters in ElementsTransitionGenerator") which must land first. BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -10 lines) Patch
M src/x87/code-stubs-x87.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M src/x87/ic-x87.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/x87/stub-cache-x87.cc View 2 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
chunyang.dai
weiliang. please help to review it. thanks.
6 years, 5 months ago (2014-07-15 10:03:10 UTC) #1
Weiliang
lgtm
6 years, 5 months ago (2014-07-15 10:40:59 UTC) #2
Weiliang
6 years, 5 months ago (2014-07-15 10:44:02 UTC) #3
Committed as r22405

Powered by Google App Engine
This is Rietveld 408576698