Issue 39193003: Fix ARM build on mac.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 39193003: Fix ARM build on mac. (Closed)

Created:
7 years, 2 months ago by Paul Lind

Modified:
7 years, 2 months ago

Reviewers:
danno, Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fix ARM build on mac. Remove a couple unused vars left behind after r16676. Clang on mac is pickier than gcc on linux, specifically gcc does not complain about unused class member variables. BUG= R=danno@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=17356

Patch Set 1 #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -5 lines)			Patch
	M	src/arm/regexp-macro-assembler-arm.h	View		1 chunk	+0 lines, -5 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Paul Lind

PTAL, a trivial change to get the ARM (sim) building on mac again.

7 years, 2 months ago (2013-10-24 05:17:31 UTC) #1

Paul Lind

7 years, 2 months ago (2013-10-24 07:03:58 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r17356 (presubmit successful).

Expand Messages | Collapse Messages