content/shell/renderer/test_runner/web_test_proxy.h - Issue 391923006: Extra parameter to pass sub-message direction for validation message

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/renderer/test_runner/web_test_proxy.h

Issue 391923006: Extra parameter to pass sub-message direction for validation message (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Unit test updated to reflect direction changes Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/renderer/render_view_impl.cc ('K') | « content/renderer/render_view_impl.cc ('k') | content/shell/renderer/test_runner/web_test_proxy.cc » ('j') | content/shell/renderer/test_runner/web_test_proxy.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/shell/renderer/test_runner/web_test_proxy.h

diff --git a/content/shell/renderer/test_runner/web_test_proxy.h b/content/shell/renderer/test_runner/web_test_proxy.h

index 7a1c6d447d960cac284706ac70872a70bf58a740..2cac1e052a96fce7a46514a94a3aa509819c86cd 100644

--- a/content/shell/renderer/test_runner/web_test_proxy.h

+++ b/content/shell/renderer/test_runner/web_test_proxy.h

@@ -108,6 +108,7 @@ class WebTestProxyBase : public blink::WebCompositeAndReadbackAsyncCallback {

blink::WebFileChooserCompletion* completion);

void ShowValidationMessage(const blink::WebRect& anchor_in_root_view,

const blink::WebString& message,

+ blink::WebTextDirection message_hint,

const blink::WebString& sub_message,

blink::WebTextDirection hint);

void HideValidationMessage();

@@ -382,10 +383,11 @@ class WebTestProxy : public Base, public WebTestProxyBase {

}

virtual void showValidationMessage(const blink::WebRect& anchor_in_root_view,

const blink::WebString& message,

+ blink::WebTextDirection message_hint,

const blink::WebString& sub_message,

blink::WebTextDirection hint) {

WebTestProxyBase::ShowValidationMessage(

- anchor_in_root_view, message, sub_message, hint);

+ anchor_in_root_view, message, message_hint, sub_message, hint);

}

virtual void postSpellCheckEvent(const blink::WebString& event_name) {

WebTestProxyBase::PostSpellCheckEvent(event_name);