Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Unified Diff: content/shell/renderer/test_runner/web_test_proxy.h

Issue 391923006: Extra parameter to pass sub-message direction for validation message (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Updated to latest master Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/render_view_impl.cc ('k') | content/shell/renderer/test_runner/web_test_proxy.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/shell/renderer/test_runner/web_test_proxy.h
diff --git a/content/shell/renderer/test_runner/web_test_proxy.h b/content/shell/renderer/test_runner/web_test_proxy.h
index 2ead7037d0e87ff18a4146ba80a373c6b0938080..027ff4ee25e45569f319684efce5eb6dab56970a 100644
--- a/content/shell/renderer/test_runner/web_test_proxy.h
+++ b/content/shell/renderer/test_runner/web_test_proxy.h
@@ -107,10 +107,8 @@ class WebTestProxyBase : public blink::WebCompositeAndReadbackAsyncCallback {
const blink::WebVector<blink::WebColorSuggestion>& suggestions);
bool RunFileChooser(const blink::WebFileChooserParams& params,
blink::WebFileChooserCompletion* completion);
- void ShowValidationMessage(const blink::WebRect& anchor_in_root_view,
- const blink::WebString& message,
- const blink::WebString& sub_message,
- blink::WebTextDirection hint);
+ void ShowValidationMessage(const base::string16& message,
+ const base::string16& sub_message);
void HideValidationMessage();
void MoveValidationMessage(const blink::WebRect& anchor_in_root_view);
@@ -377,11 +375,18 @@ class WebTestProxy : public Base, public WebTestProxyBase {
return WebTestProxyBase::RunFileChooser(params, completion);
}
virtual void showValidationMessage(const blink::WebRect& anchor_in_root_view,
- const blink::WebString& message,
+ const blink::WebString& main_message,
+ blink::WebTextDirection main_message_hint,
const blink::WebString& sub_message,
- blink::WebTextDirection hint) {
+ blink::WebTextDirection sub_message_hint) {
+ base::string16 wrapped_main_text = main_message;
+ base::string16 wrapped_sub_text = sub_message;
+
+ Base::SetValidationMessageDirection(
+ &wrapped_main_text, main_message_hint, &wrapped_sub_text, sub_message_hint);
+
WebTestProxyBase::ShowValidationMessage(
- anchor_in_root_view, message, sub_message, hint);
+ wrapped_main_text, wrapped_sub_text);
}
virtual void postSpellCheckEvent(const blink::WebString& event_name) {
WebTestProxyBase::PostSpellCheckEvent(event_name);
« no previous file with comments | « content/renderer/render_view_impl.cc ('k') | content/shell/renderer/test_runner/web_test_proxy.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698