Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Issue 391873003: Files.app: random code clean up. (Closed)

Created:
6 years, 5 months ago by kinaba
Modified:
6 years, 5 months ago
Reviewers:
hirono
CC:
chromium-reviews, nkostylev+watch_chromium.org, yoshiki+watch_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Files.app: random code clean up. * Fix typo. * Remove unused code. * Move IsFallbackFileBrowserHandler to file_tasks.cc since it is no more specific to fileBrowserHandler. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283302

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -64 lines) Patch
M chrome/browser/chromeos/file_manager/app_installer.h View 2 chunks +2 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/file_manager/app_installer.cc View 3 chunks +8 lines, -17 lines 0 comments Download
M chrome/browser/chromeos/file_manager/file_browser_handlers.h View 2 chunks +0 lines, -9 lines 0 comments Download
M chrome/browser/chromeos/file_manager/file_browser_handlers.cc View 2 chunks +0 lines, -12 lines 0 comments Download
M chrome/browser/chromeos/file_manager/file_tasks.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/file_manager/file_tasks.cc View 7 chunks +26 lines, -10 lines 0 comments Download
M chrome/browser/chromeos/file_manager/file_tasks_unittest.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/file_manager.js View 1 chunk +1 line, -1 line 0 comments Download
M ui/file_manager/file_manager/foreground/js/file_manager_commands.js View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
kinaba
6 years, 5 months ago (2014-07-15 05:21:31 UTC) #1
hirono
lgtm! Thank you!
6 years, 5 months ago (2014-07-15 05:28:02 UTC) #2
kinaba
The CQ bit was checked by kinaba@chromium.org
6 years, 5 months ago (2014-07-15 05:28:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/391873003/20001
6 years, 5 months ago (2014-07-15 05:31:20 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_x64_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-15 20:31:51 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-16 00:28:18 UTC) #6
Message was sent while issue was closed.
Change committed as 283302

Powered by Google App Engine
This is Rietveld 408576698