Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1047)

Unified Diff: build/toolchain.gypi

Issue 39183004: Define DEBUG for v8_optimized_debug=2 (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: More tweaks Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/ast.cc » ('j') | src/checks.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/toolchain.gypi
diff --git a/build/toolchain.gypi b/build/toolchain.gypi
index e1903f300fd757090f123a16f7456880b9779748..02dc2bce7eba3e577faf428fa9c0763970c0a8c0 100644
--- a/build/toolchain.gypi
+++ b/build/toolchain.gypi
@@ -533,15 +533,18 @@
['v8_optimized_debug==1', {
'cflags!': [
'-O0',
- '-O3', # TODO(2807) should be -O1.
+ '-O1',
'-O2',
'-Os',
],
'cflags': [
'-fdata-sections',
'-ffunction-sections',
- '-O1', # TODO(2807) should be -O3.
+ '-O3'
],
+ 'defines': [
+ 'OPTIMIZED_DEBUG'
+ ]
}],
['v8_optimized_debug==2', {
'cflags!': [
« no previous file with comments | « no previous file | src/ast.cc » ('j') | src/checks.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698