Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Issue 391813006: [Android] Add meta-data to point to implementations of SmartClipProvider (Closed)

Created:
6 years, 5 months ago by Changwan Ryu
Modified:
6 years, 5 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, jochen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Android] Add meta-data to point to implementations of SmartClipProvider Also enhance SmartClipProviderTest to emulate what OEM will do. BUG=388961 TEST=passed SmartClipProviderTest Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284018

Patch Set 1 #

Patch Set 2 : removed contentview reference, enhanced test using reflection #

Patch Set 3 : added comment #

Patch Set 4 : fixed meta data value for content shell #

Patch Set 5 : removed "_VIEW" #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -130 lines) Patch
D chrome/android/javatests/src/org/chromium/chrome/browser/ContentViewTest.java View 1 1 chunk +0 lines, -123 lines 0 comments Download
A + chrome/android/javatests/src/org/chromium/chrome/browser/SmartClipProviderTest.java View 1 2 3 4 4 chunks +66 lines, -7 lines 0 comments Download
M chrome/android/shell/java/AndroidManifest.xml View 1 2 3 4 1 chunk +3 lines, -0 lines 0 comments Download
M content/shell/android/shell_apk/AndroidManifest.xml View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Changwan Ryu
6 years, 5 months ago (2014-07-15 06:30:59 UTC) #1
Yaron
lgtm
6 years, 5 months ago (2014-07-17 01:17:19 UTC) #2
Changwan Ryu
The CQ bit was checked by changwan@chromium.org
6 years, 5 months ago (2014-07-17 23:40:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/changwan@chromium.org/391813006/80001
6 years, 5 months ago (2014-07-17 23:42:40 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-18 04:11:43 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-18 05:56:45 UTC) #6
Message was sent while issue was closed.
Change committed as 284018

Powered by Google App Engine
This is Rietveld 408576698