Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Issue 391793002: When NEON disabled, always build ARM memset routines. (Closed)

Created:
6 years, 5 months ago by DaleCurtis
Modified:
6 years, 5 months ago
Reviewers:
djsollen, mtklein, reed1
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

When NEON disabled, always build ARM memset routines. Fixes: ...SkUtils_opts_arm.cpp:36:error: undefined reference to 'arm_memset16' ...SkUtils_opts_arm.cpp:53:error: undefined reference to 'arm_memset32' BUG=155921, 277433 TEST=Fixes missing memset routine during linking. R=mtklein@google.com, reed@google.com Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283220

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M skia/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M skia/skia_library_opts.gyp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (0 generated)
DaleCurtis
Seems correct, otherwise runtime selection wouldn't be able to select between regular or neon. Fixes ...
6 years, 5 months ago (2014-07-14 18:44:37 UTC) #1
reed1
6 years, 5 months ago (2014-07-14 20:27:33 UTC) #2
mtklein
lgtm
6 years, 5 months ago (2014-07-14 20:30:10 UTC) #3
DaleCurtis
The CQ bit was checked by dalecurtis@chromium.org
6 years, 5 months ago (2014-07-14 20:58:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dalecurtis@chromium.org/391793002/1
6 years, 5 months ago (2014-07-14 21:00:04 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-14 21:00:05 UTC) #6
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 5 months ago (2014-07-14 21:00:06 UTC) #7
DaleCurtis
Any superstars comfortable LGTM'ing this? The GN build for media is waiting on it.
6 years, 5 months ago (2014-07-14 23:02:13 UTC) #8
reed1
lgtm
6 years, 5 months ago (2014-07-15 13:38:48 UTC) #9
DaleCurtis
The CQ bit was checked by dalecurtis@chromium.org
6 years, 5 months ago (2014-07-15 17:25:28 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dalecurtis@chromium.org/391793002/1
6 years, 5 months ago (2014-07-15 17:27:38 UTC) #11
DaleCurtis
6 years, 5 months ago (2014-07-15 18:22:56 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 manually as r283220 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698