Enabling CRLSet for ChromeOS

chrome/browser/net/crl_set_fetcher.h

Index: chrome/browser/net/crl_set_fetcher.h
diff --git a/chrome/browser/net/crl_set_fetcher.h b/chrome/browser/net/crl_set_fetcher.h
index c7536cc7ca27cdb3d9cc943d3c6e89ec0629200c..cdd20d770cd1cc004ad1f45f6940620f4399dc3d 100644
--- a/chrome/browser/net/crl_set_fetcher.h
+++ b/chrome/browser/net/crl_set_fetcher.h
@@ -8,6 +8,7 @@
 #include <string>
 
 #include "base/compiler_specific.h"
+#include "base/files/file_path.h"
 #include "base/memory/ref_counted.h"
 #include "chrome/browser/component_updater/component_updater_service.h"
 
@@ -27,6 +28,9 @@ class CRLSetFetcher : public component_updater::ComponentInstaller,
 
   void StartInitialLoad(component_updater::ComponentUpdateService* cus);
 
+  void StartInitialLoadWithHash(component_updater::ComponentUpdateService* cus,
+                                const std::string& user_id_hash);

[Ryan Sleevi, 2014/07/16 19:39:28]

This seems like a very ChromeOS-specific concept, in that it doesn't really make
sense (at an interface level) on our other platforms.

We should find a way to abstract this knowledge, so that it's truly
ChromeOS-only.

+
   // DeleteFromDisk asynchronously delete the CRLSet file.
   void DeleteFromDisk();
 
@@ -44,7 +48,14 @@ class CRLSetFetcher : public component_updater::ComponentInstaller,
 
   // GetCRLSetbase::FilePath gets the path of the CRL set file in the user data
   // dir.
-  bool GetCRLSetFilePath(base::FilePath* path) const;
+  base::FilePath GetCRLSetFilePath() const;
+
+  // Set the path of the CRL set file in the user data dir.

[Jorge Lucangeli Obes, 2014/07/16 16:36:34]

"Sets", comments are usually not written in imperative form.

+  // Optional |user_id_hash| that is used by ChromeOS.

[Jorge Lucangeli Obes, 2014/07/16 16:36:34]

"Chrome OS" with a space.

+  bool SetCRLSetFilePath(const std::string* user_id_hash);
+
+  // Posts DoInitialLoadFromDisk to the FILE Thread.
+  void PostInitialLoad(component_updater::ComponentUpdateService* cus);
 
   // DoInitialLoadFromDisk runs on the FILE thread and attempts to load a CRL
   // set from the user-data dir. It then registers this object as a component
@@ -69,6 +80,9 @@ class CRLSetFetcher : public component_updater::ComponentInstaller,
 
   component_updater::ComponentUpdateService* cus_;
 
+  // Path where CRL file is stored.
+  base::FilePath crl_path_;
+
   // We keep a pointer to the current CRLSet for use on the FILE thread when
   // applying delta updates.
   scoped_refptr<net::CRLSet> crl_set_;