Enabling CRLSet for ChromeOS

chrome/browser/chromeos/login/users/user_manager_impl.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/login/users/user_manager_impl.h"
 
 #include <cstddef>
 #include <set>
 
 #include "ash/multi_profile_uma.h"
@@ skipping 25 matching lines @@
 #include "chrome/browser/chromeos/login/signin/auth_sync_observer_factory.h"
 #include "chrome/browser/chromeos/login/users/avatar/user_image_manager_impl.h"
 #include "chrome/browser/chromeos/login/users/multi_profile_user_controller.h"
 #include "chrome/browser/chromeos/login/users/remove_user_delegate.h"
 #include "chrome/browser/chromeos/login/users/supervised_user_manager_impl.h"
 #include "chrome/browser/chromeos/policy/browser_policy_connector_chromeos.h"
 #include "chrome/browser/chromeos/policy/device_local_account.h"
 #include "chrome/browser/chromeos/profiles/multiprofiles_session_aborted_dialog.h"
 #include "chrome/browser/chromeos/profiles/profile_helper.h"
 #include "chrome/browser/chromeos/session_length_limiter.h"
+#include "chrome/browser/net/crl_set_fetcher.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/supervised_user/chromeos/manager_password_service_factory.h"
 #include "chrome/browser/supervised_user/chromeos/supervised_user_password_service_factory.h"
 #include "chrome/common/chrome_constants.h"
 #include "chrome/common/chrome_paths.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/common/crash_keys.h"
 #include "chrome/common/pref_names.h"
 #include "chromeos/chromeos_switches.h"
 #include "chromeos/cryptohome/async_method_caller.h"
@@ skipping 376 matching lines @@
   DCHECK(active_user_);
   active_user_->set_is_logged_in(true);
   active_user_->set_is_active(true);
   active_user_->set_username_hash(username_hash);
 
   // Place user who just signed in to the top of the logged in users.
   logged_in_users_.insert(logged_in_users_.begin(), active_user_);
   SetLRUUser(active_user_);
 
   if (!primary_user_) {
+    // Register CRLSet now that the home dir is mounted.
+    base::FilePath path;
+    if (!username_hash.empty() &&
+        PathService::Get(chrome::DIR_USER_DATA, &path)) {
+      path = path.Append(
+          chromeos::ProfileHelper::GetUserProfileDir(username_hash));

[xiyuan, 2014/07/18 19:38:27]

You can use ProfileHelper::GetProfilePathByUserIdHash to get full profile path
instead of appending manually here.

[leecam, 2014/07/19 06:36:39]

I tried this call first but it uses the profile manager
g_browser_process->profile_manager() and the the profile for this user is not
set up yet.

[xiyuan, 2014/07/21 16:37:59]

GetProfilePathByUserIdHash only needs the user_data_dir from profile manager. I
don't see where it tries to access the user profile. What error did you get?

+      component_updater::ComponentUpdateService* cus =
+          g_browser_process->component_updater();
+      CRLSetFetcher* crl_set = g_browser_process->crl_set_fetcher();
+      if (crl_set && cus)
+        crl_set->StartInitialLoad(cus, path);
+    }
     primary_user_ = active_user_;
     if (primary_user_->GetType() == user_manager::USER_TYPE_REGULAR)
       SendRegularUserLoginMetrics(user_id);
   }
 
   UMA_HISTOGRAM_ENUMERATION("UserManager.LoginUserType",
                             active_user_->GetType(),
                             user_manager::NUM_USER_TYPES);
 
   g_browser_process->local_state()->SetString(
@@ skipping 1321 matching lines @@
 }
 
 void UserManagerImpl::DeleteUser(User* user) {
   const bool is_active_user = (user == active_user_);
   delete user;
   if (is_active_user)
     active_user_ = NULL;
 }
 
 }  // namespace chromeos