Chromium Code Reviews| Index: net/http/http_cache_unittest.cc |
| diff --git a/net/http/http_cache_unittest.cc b/net/http/http_cache_unittest.cc |
| index 83241ab301e441665f6acf3f1b794fa7e5f9f183..4f6a4a8224a9b99c4d0784d0a0ab152c6043618f 100644 |
| --- a/net/http/http_cache_unittest.cc |
| +++ b/net/http/http_cache_unittest.cc |
| @@ -6443,3 +6443,89 @@ TEST(HttpCache, ReceivedBytesRange) { |
| RemoveMockTransaction(&kRangeGET_TransactionOK); |
| } |
| + |
| +static void CheckChromeFreshnessHeader(const net::HttpRequestInfo* request, |
| + std::string* response_status, |
| + std::string* response_headers, |
| + std::string* response_data) { |
| + std::string value; |
| + EXPECT_TRUE(request->extra_headers.GetHeader("Chrome-Freshness", &value)); |
| + // 228658821 seconds is around 7.25 years. |
| + // TODO(ricea): Find out why we get this number, and why it is always the |
| + // same. |
|
tyoshino (SeeGerritForStatus)
2014/07/23 00:08:56
Hmm... FYI, 18 Apr 2007 01:10:43 + 228658821sec =
|
| + EXPECT_EQ("max-age=3600,stale-while-revalidate=7200,age=228658821", value); |
| +} |
| + |
| +// Verify that the Chrome-Freshness header is sent on a revalidation if the |
| +// stale-while-revalidate directive was on the response. |
| +// TODO(ricea): Rename this test when a final name for the header is decided. |
| +TEST(HttpCache, ChromeFreshnessHeaderSent) { |
| + MockHttpCache cache; |
| + |
| + const MockTransaction kStaleWhileRevalidateTransaction = { |
| + "http://www.example.com/stale-while-revalidate", |
| + "GET", |
| + base::Time(), |
| + "", |
| + net::LOAD_NORMAL, |
| + "HTTP/1.1 200 OK", |
| + "Last-Modified: Sat, 18 Apr 2007 01:10:43 GMT\n" |
| + "Cache-Control: max-age=3600,stale-while-revalidate=7200\n", |
| + base::Time(), |
| + "<title>Testing stale-while-revalidate</title>", |
| + TEST_MODE_SYNC_NET_START, |
| + NULL, |
| + 0, |
| + net::OK}; |
| + |
| + ScopedMockTransaction stale_while_revalidate_transaction( |
| + kStaleWhileRevalidateTransaction); |
| + |
| + // Write to the cache. |
| + RunTransactionTest(cache.http_cache(), stale_while_revalidate_transaction); |
| + |
| + // Send the request again and check that Chrome-Freshness header is added. |
| + stale_while_revalidate_transaction.handler = CheckChromeFreshnessHeader; |
| + |
| + RunTransactionTest(cache.http_cache(), stale_while_revalidate_transaction); |
| +} |
| + |
| +static void CheckChromeFreshnessAbsent(const net::HttpRequestInfo* request, |
| + std::string* response_status, |
| + std::string* response_headers, |
| + std::string* response_data) { |
| + EXPECT_FALSE(request->extra_headers.HasHeader("Chrome-Freshness")); |
| +} |
| + |
| +// Verify that the Chrome-Freshness header is not sent when cookies are |
| +// disabled. |
| +TEST(HttpCache, ChromeFreshnessHeaderNotSent) { |
| + MockHttpCache cache; |
| + |
| + const MockTransaction kStaleWhileRevalidateTransaction = { |
| + "http://www.example.com/stale-while-revalidate", |
| + "GET", |
| + base::Time(), |
| + "", |
| + net::LOAD_DO_NOT_SEND_COOKIES, |
| + "HTTP/1.1 200 OK", |
| + "Last-Modified: Sat, 18 Apr 2007 01:10:43 GMT\n" |
| + "Cache-Control: max-age=3600,stale-while-revalidate=7200\n", |
| + base::Time(), |
| + "<title>Testing stale-while-revalidate</title>", |
| + TEST_MODE_SYNC_NET_START, |
| + NULL, |
| + 0, |
| + net::OK}; |
| + |
| + ScopedMockTransaction stale_while_revalidate_transaction( |
| + kStaleWhileRevalidateTransaction); |
| + |
| + // Write to the cache. |
| + RunTransactionTest(cache.http_cache(), stale_while_revalidate_transaction); |
| + |
| + // Send the request again and check that Chrome-Freshness header is absent. |
| + stale_while_revalidate_transaction.handler = CheckChromeFreshnessAbsent; |
| + |
| + RunTransactionTest(cache.http_cache(), stale_while_revalidate_transaction); |
| +} |