Issue 39173: Location bar should have focus when whosing NTP

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 39173: Location bar should have focus when whosing NTP (Closed)

Created:
11 years, 9 months ago by jcampan

Modified:
9 years, 7 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews_googlegroups.com, Glen Murphy

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

The new history and download tab caused a regression where opening the NTP would not focus the location bar. DOM UI now by default focus the page. The NTP one focus the location bar. Also removed some unused fields from the history and download DOM UI. BUG=8356 TEST=Open NTP, focus should be on location bar Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=11034

Patch Set 1 #

Patch Set 2 : '' #

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -13 lines)			Patch
M	chrome/browser/dom_ui/dom_ui.h	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/dom_ui/dom_ui.cc	View	1	1 chunk	+0 lines, -4 lines	0 comments	Download
M	chrome/browser/dom_ui/dom_ui_contents.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/dom_ui/dom_ui_contents.cc	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/dom_ui/downloads_ui.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/dom_ui/history_ui.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/views/frame/browser_frame.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/views/frame/browser_view.cc	View		1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

jcampan

Ben, could you look at this since Glen is out? I had an original fix ...

11 years, 9 months ago (2009-03-05 19:38:52 UTC) #3

OK

Expand Messages | Collapse Messages