Reland "Include symbol properties in Object.{create,defineProperties}"

Reland "Include symbol properties in Object.{create,defineProperties}"

Second try; implementation that doesn't rely on external arrays.

R=mstarzinger@chromium.org
BUG=v8:3440
Committed: https://code.google.com/p/v8/source/detail?r=22378

[arv (Not doing code reviews), 2014-07-14 13:29:17]

FYI

https://codereview.chromium.org/391713002/diff/1/src/v8natives.js
File src/v8natives.js (right):

https://codereview.chromium.org/391713002/diff/1/src/v8natives.js#newcode1183
src/v8natives.js:1183: var filter = PROPERTY_ATTRIBUTES_STRING |
PROPERTY_ATTRIBUTES_PRIVATE_SYMBOL;
Why don't you include string property keys here too and you can remove the loop
above.

[Michael Starzinger, 2014-07-14 13:30:23]

LGTM.

[rossberg, 2014-07-14 13:50:10]

https://codereview.chromium.org/391713002/diff/1/src/v8natives.js
File src/v8natives.js (right):

https://codereview.chromium.org/391713002/diff/1/src/v8natives.js#newcode1183
src/v8natives.js:1183: var filter = PROPERTY_ATTRIBUTES_STRING |
PROPERTY_ATTRIBUTES_PRIVATE_SYMBOL;
On 2014/07/14 13:29:17, arv wrote:
> Why don't you include string property keys here too and you can remove the
loop
> above.

Unfortunately, that would miss out on indexed properties.

[rossberg, 2014-07-14 14:00:40]

Committed patchset #1 manually as r22378 (tree was closed).

[arv (Not doing code reviews), 2014-07-14 15:14:29]

On 2014/07/14 at 13:50:10, rossberg wrote:
> https://codereview.chromium.org/391713002/diff/1/src/v8natives.js
> File src/v8natives.js (right):
> 
> https://codereview.chromium.org/391713002/diff/1/src/v8natives.js#newcode1183
> src/v8natives.js:1183: var filter = PROPERTY_ATTRIBUTES_STRING |
PROPERTY_ATTRIBUTES_PRIVATE_SYMBOL;
> On 2014/07/14 13:29:17, arv wrote:
> > Why don't you include string property keys here too and you can remove the
loop
> > above.
> 
> Unfortunately, that would miss out on indexed properties.

Too bad. It feels dirty to have two loops. One that filters out symbols and one
that filters out strings.