Implement ConstraintNotSatisfiedError for getusermedia

content/renderer/pepper/pepper_media_stream_video_track_host.h

Index: content/renderer/pepper/pepper_media_stream_video_track_host.h
diff --git a/content/renderer/pepper/pepper_media_stream_video_track_host.h b/content/renderer/pepper/pepper_media_stream_video_track_host.h
index 178eaefbd10502abbce50fd836f90db5610dc459..5d81abd4177aba93088908621e207a0eb78ef778 100644
--- a/content/renderer/pepper/pepper_media_stream_video_track_host.h
+++ b/content/renderer/pepper/pepper_media_stream_video_track_host.h
@@ -85,7 +85,9 @@ class PepperMediaStreamVideoTrackHost : public PepperMediaStreamTrackHostBase,
       const ppapi::MediaStreamVideoTrackShared::Attributes& attributes);
 
   void InitBlinkTrack();
-  void OnTrackStarted(MediaStreamSource* source, bool success);
+  void OnTrackStarted(MediaStreamSource* source,
+                      content::MediaStreamRequestResult result,

[yzshen1, 2014/07/25 17:48:49]

content:: is not needed.

+                      const blink::WebString& result_name = blink::WebString());

[yzshen1, 2014/07/25 17:48:49]

Do you really need this default value?
In general default value is not recommended.

[jiajia.qin, 2014/07/28 05:10:20]

In the spec, it says if it is the ConstraintNotSatisfiedError, we need to set
the constraintName that caused the error. But for other error type, it doesn't
say. So here I use a default value. If the result is
CONSTRAINT_NOT_SATISFIED_ERROR, I will transfer the result_name(constraint_name)
too. Otherwise, I only transfer the result and use the default value.

[yzshen1, 2014/07/28 17:37:18]

Could we pass an empty string in the cases that we don't need it, instead of
using a default value?

 
   blink::WebMediaStreamTrack track_;