content/renderer/media/media_stream_video_capturer_source.cc - Issue 391703002: Implement ConstraintNotSatisfiedError for getusermedia

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/media_stream_video_capturer_source.cc

Issue 391703002: Implement ConstraintNotSatisfiedError for getusermedia (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add bug id and reviewer Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/renderer/media/media_stream_impl.h ('K') | « content/renderer/media/media_stream_video_capturer_source.h ('k') | content/renderer/media/media_stream_video_source.h » ('j') | content/renderer/media/media_stream_video_source.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/media/media_stream_video_capturer_source.cc

diff --git a/content/renderer/media/media_stream_video_capturer_source.cc b/content/renderer/media/media_stream_video_capturer_source.cc

index f4555afb4f011cb1f42f18cddb49d05907b37556..8f592d18e03abe6061c443a5dd6286e896d66006 100644

--- a/content/renderer/media/media_stream_video_capturer_source.cc

+++ b/content/renderer/media/media_stream_video_capturer_source.cc

@@ -137,11 +137,12 @@ void VideoCapturerDelegate::OnStateUpdateOnRenderThread(

DCHECK(thread_checker_.CalledOnValidThread());

DVLOG(3) << "OnStateUpdateOnRenderThread state = " << state;

if (state == VIDEO_CAPTURE_STATE_STARTED && !running_callback_.is_null()) {

- running_callback_.Run(true);

+ running_callback_.Run(MEDIA_DEVICE_OK);

return;

}

if (state > VIDEO_CAPTURE_STATE_STARTED && !running_callback_.is_null()) {

- base::ResetAndReturn(&running_callback_).Run(false);

+ base::ResetAndReturn(&running_callback_).Run(

+ MEDIA_DEVICE_TRACK_START_FAILURE);

no longer working on chromium 2014/07/25 19:27:35 why isn't it MEDIA_DEVICE_SOURCE_START_FAILURE ?

}