content/renderer/media/webrtc/media_stream_remote_video_source_unittest.cc - Issue 391703002: Implement ConstraintNotSatisfiedError for getusermedia

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/webrtc/media_stream_remote_video_source_unittest.cc

Issue 391703002: Implement ConstraintNotSatisfiedError for getusermedia (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase and change the reviewers list Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/renderer/media/webrtc/media_stream_remote_video_source.cc ('k') | content/renderer/media/webrtc/video_destination_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/media/webrtc/media_stream_remote_video_source_unittest.cc

diff --git a/content/renderer/media/webrtc/media_stream_remote_video_source_unittest.cc b/content/renderer/media/webrtc/media_stream_remote_video_source_unittest.cc

index c6b50ec25eb227e1e48111d0847a74346acbdc72..e2a4176d6c7e806380dda7d7164c6d744caa1856 100644

--- a/content/renderer/media/webrtc/media_stream_remote_video_source_unittest.cc

+++ b/content/renderer/media/webrtc/media_stream_remote_video_source_unittest.cc

@@ -84,9 +84,11 @@ class MediaStreamRemoteVideoSourceTest

}

private:

- void OnConstraintsApplied(MediaStreamSource* source, bool success) {

+ void OnConstraintsApplied(MediaStreamSource* source,

+ MediaStreamRequestResult result,

+ const blink::WebString& result_name) {

ASSERT_EQ(source, remote_source_);

- if (success)

+ if (result == MEDIA_DEVICE_OK)

++number_of_successful_constraints_applied_;

else

++number_of_failed_constraints_applied_;