content/browser/media/webrtc_getusermedia_browsertest.cc - Issue 391703002: Implement ConstraintNotSatisfiedError for getusermedia

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/media/webrtc_getusermedia_browsertest.cc

Issue 391703002: Implement ConstraintNotSatisfiedError for getusermedia (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase and change the reviewers list Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/media/webrtc_getusermedia_browsertest.cc

diff --git a/content/browser/media/webrtc_getusermedia_browsertest.cc b/content/browser/media/webrtc_getusermedia_browsertest.cc

index 9efa23e9b2911d0fa1ff6f17d9b6522043434ece..653e0edde56f05b7a885e4e5f2825287102cdf72 100644

--- a/content/browser/media/webrtc_getusermedia_browsertest.cc

+++ b/content/browser/media/webrtc_getusermedia_browsertest.cc

@@ -503,8 +503,8 @@ IN_PROC_BROWSER_TEST_F(WebRtcGetUserMediaBrowserTest,

large_value);

NavigateToURL(shell(), url);

- // TODO(perkj): A proper error code should be returned by gUM.

- EXPECT_EQ("TrackStartError", ExecuteJavascriptAndReturnResult(call));

+ EXPECT_EQ("ConstraintNotSatisfiedError",

+ ExecuteJavascriptAndReturnResult(call));

}

// This test will make a simple getUserMedia page, verify that video is playing

« no previous file with comments | « AUTHORS ('k') | content/public/common/media_stream_request.h » ('j') | no next file with comments »