Implement ConstraintNotSatisfiedError for getusermedia

content/renderer/media/media_stream_video_source.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_RENDERER_MEDIA_MEDIA_STREAM_VIDEO_SOURCE_H_
 #define CONTENT_RENDERER_MEDIA_MEDIA_STREAM_VIDEO_SOURCE_H_
 
 #include <string>
 #include <vector>
 
@@ skipping 90 matching lines @@
 
   // An implementation must start capture frames using the resolution in
   // |params|. When the source has started or the source failed to start
   // OnStartDone must be called. An implementation must call
   // invoke |frame_callback| on the IO thread with the captured frames.
   // TODO(perkj): pass a VideoCaptureFormats instead of VideoCaptureParams for
   // subclasses to customize.
   virtual void StartSourceImpl(
       const media::VideoCaptureParams& params,
       const VideoCaptureDeliverFrameCB& frame_callback) = 0;
-  void OnStartDone(bool success);
+  void OnStartDone(content::MediaStreamRequestResult result);

[no longer working on chromium, 2014/07/28 19:55:08]

nit, you don't need content::

[jiajia.qin, 2014/07/30 05:18:07]

Done.

 
   // An implementation must immediately stop capture video frames and must not
   // call OnSupportedFormats after this method has been called. After this
   // method has been called, MediaStreamVideoSource may be deleted.
   virtual void StopSourceImpl() = 0;
 
   enum State {
     NEW,
     RETRIEVING_CAPABILITIES,
     STARTING,
@@ skipping 12 matching lines @@
       const media::VideoCaptureFormats& formats,
       media::VideoCaptureFormat* best_format);
 
   // Trigger all cached callbacks from AddTrack. AddTrack is successful
   // if the capture delegate has started and the constraints provided in
   // AddTrack match the format that was used to start the device.
   // Note that it must be ok to delete the MediaStreamVideoSource object
   // in the context of the callback. If gUM fail, the implementation will
   // simply drop the references to the blink source and track which will lead
   // to that this object is deleted.
-  void FinalizeAddTrack();
+  void FinalizeAddTrack(content::MediaStreamRequestResult result);

[no longer working on chromium, 2014/07/28 19:55:08]

ditto

[jiajia.qin, 2014/07/30 05:18:07]

Done.

 
   State state_;
 
+  // constraintName_ is used to record the name of constraint
+  // that causes ConstraintNotSatisfiedError
+  blink::WebString constraintName_;

[no longer working on chromium, 2014/07/28 19:55:08]

how about changing the name to unsatisfied_constraint_

[jiajia.qin, 2014/07/30 05:18:08]

Done.

   media::VideoCaptureFormat current_format_;
 
   struct RequestedConstraints {
     RequestedConstraints(MediaStreamVideoTrack* track,
                          const VideoCaptureDeliverFrameCB& frame_callback,
                          const blink::WebMediaConstraints& constraints,
                          const ConstraintsCallback& callback);
     ~RequestedConstraints();
 
     MediaStreamVideoTrack* track;
@@ skipping 13 matching lines @@
 
   // NOTE: Weak pointers must be invalidated before all other member variables.
   base::WeakPtrFactory<MediaStreamVideoSource> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(MediaStreamVideoSource);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_RENDERER_MEDIA_MEDIA_STREAM_VIDEO_SOURCE_H_