src/hydrogen-instructions.h - Issue 391693002: In-object double fields unboxing (for 64-bit only).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/hydrogen-instructions.h

Issue 391693002: In-object double fields unboxing (for 64-bit only). (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Addressed Toon's comments Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/hydrogen-instructions.h

diff --git a/src/hydrogen-instructions.h b/src/hydrogen-instructions.h

index b08bc7705a71b4bf9991554cc1ea708ffdc5c179..cbcb7e8d2bd26eec80c8aca08e63d4ad2708c9fb 100644

--- a/src/hydrogen-instructions.h

+++ b/src/hydrogen-instructions.h

@@ -6887,7 +6887,9 @@ class HStoreNamedField FINAL : public HTemplateInstruction<3> {

}

bool NeedsWriteBarrier() const {

- DCHECK(!field_representation().IsDouble() || !has_transition());

+ DCHECK(!field_representation().IsDouble() ||

+ (FLAG_unbox_double_fields && access_.IsInobject()) ||

+ !has_transition());

if (field_representation().IsDouble()) return false;

if (field_representation().IsSmi()) return false;

if (field_representation().IsInteger32()) return false;