Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: src/layout-descriptor.h

Issue 391693002: In-object double fields unboxing (for 64-bit only). (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressed Toon's comments Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
(Empty)
1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #ifndef V8_LAYOUT_DESCRIPTOR_H_
6 #define V8_LAYOUT_DESCRIPTOR_H_
7
8 #include <iosfwd>
9
10 #include "src/objects.h"
11
12 namespace v8 {
13 namespace internal {
14
15 // LayoutDescriptor is a bit vector defining which fields contain non-tagged
16 // values. It could either be a fixed typed array (slow form) or a Smi
17 // if the length fits (fast form).
18 // Each bit in the layout represents a FIELD. The bits are referenced by
19 // field_index which is a field number. If the bit is set then corresponding
20 // field contains non tagged value and therefore must be skipped by GC.
Hannes Payer (out of office) 2014/11/06 12:29:46 ... *the* corresponding field contains *a* non-tag
Igor Sheludko 2014/11/07 08:03:52 Done.
21 // Otherwise the field is considered tagged. If the queried bit lays "outside"
22 // of the descriptor then the field is also considered tagged.
23 // Once a layout descriptor is created it is allowed only to append properties
24 // to it.
25 class LayoutDescriptor : public FixedTypedArray<Uint32ArrayTraits> {
26 public:
27 V8_INLINE bool IsTagged(int field_index);
28
29 // Returns true if this is a layout of the object having only tagged fields.
30 V8_INLINE bool IsFastPointerLayout();
31
32 // Returns true if the layout descriptor is in non-Smi form.
33 V8_INLINE bool IsSlowLayout();
34
35 V8_INLINE static LayoutDescriptor* cast(Object* object);
36 V8_INLINE static const LayoutDescriptor* cast(const Object* object);
37
38 V8_INLINE static LayoutDescriptor* cast_gc_safe(Object* object);
39
40 // Builds layout descriptor optimized for given |map| by |num_descriptors|
41 // elements of given descriptors array. The |map|'s descriptors could be
42 // different.
43 static Handle<LayoutDescriptor> New(Handle<Map> map,
44 Handle<DescriptorArray> descriptors,
45 int num_descriptors);
46
47 // Creates new layout descriptor by appending property with |details| to
48 // |map|'s layout descriptor.
49 static Handle<LayoutDescriptor> Append(Handle<Map> map,
50 PropertyDetails details);
51
52 // Creates new layout descriptor by appending property with |details| to
53 // |map|'s layout descriptor and if it is still fast then returns it.
54 // Otherwise the |full_layout_descriptor| is returned.
55 static Handle<LayoutDescriptor> AppendIfFastOrUseFull(
56 Handle<Map> map, PropertyDetails details,
57 Handle<LayoutDescriptor> full_layout_descriptor);
58
59 // Layout descriptor that corresponds to an object all fields of which are
60 // tagged (FastPointerLayout).
61 V8_INLINE static LayoutDescriptor* FastPointerLayout();
62
63 #ifdef DEBUG
64 // Check that this layout descriptor corresponds to given map.
65 bool IsConsistentWithMap(Map* map);
66 #endif
67
68 #ifdef OBJECT_PRINT
69 // For our gdb macros, we should perhaps change these in the future.
70 void Print();
71
72 void Print(std::ostream& os); // NOLINT
73 #endif
74
75 private:
76 static const int kNumberOfBits = 32;
77
78 V8_INLINE static Handle<LayoutDescriptor> New(Isolate* isolate, int length);
79 V8_INLINE static LayoutDescriptor* FromSmi(Smi* smi);
80
81 V8_INLINE static bool InobjectUnboxedField(int inobject_properties,
82 PropertyDetails details);
83
84 static Handle<LayoutDescriptor> EnsureCapacity(
85 Isolate* isolate, Handle<LayoutDescriptor> layout_descriptor,
86 int new_capacity);
87
88 // Returns false if requested field_index is out of bounds.
89 V8_INLINE bool GetIndexes(int field_index, int* layout_word_index,
90 uint32_t* layout_mask);
91
92 V8_INLINE MUST_USE_RESULT LayoutDescriptor* SetRawData(int field_index) {
93 return SetTagged(field_index, false);
94 }
95
96 V8_INLINE MUST_USE_RESULT LayoutDescriptor* SetTagged(int field_index,
97 bool tagged);
98 // Capacity of layout descriptors in bits.
99 V8_INLINE int capacity();
100
101 friend class TestAccessor;
102 };
103
104
105 // InobjectPropertiesHelper is a helper class for querying layout descriptor
106 // about whether the field at given offset is tagged or not.
107 class InobjectPropertiesHelper {
108 public:
109 inline explicit InobjectPropertiesHelper(Map* map);
110
111 bool all_fields_tagged() { return all_fields_tagged_; }
112 inline bool IsTagged(int offset_in_bytes);
113
114 private:
115 bool all_fields_tagged_;
116 int header_size_;
117 int inobject_properties_count_;
118 LayoutDescriptor* layout_descriptor_;
119 };
120 }
121 } // namespace v8::internal
122
123 #endif // V8_LAYOUT_DESCRIPTOR_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698