Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1244)

Side by Side Diff: src/globals.h

Issue 391693002: In-object double fields unboxing (for 64-bit only). (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressed Toon's comments Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_GLOBALS_H_ 5 #ifndef V8_GLOBALS_H_
6 #define V8_GLOBALS_H_ 6 #define V8_GLOBALS_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 #include <stdint.h> 9 #include <stdint.h>
10 10
(...skipping 67 matching lines...) Expand 10 before | Expand all | Expand 10 after
78 // stack allocating MacroAssembler takes 120K bytes. 78 // stack allocating MacroAssembler takes 120K bytes.
79 // See issue crbug.com/405338 79 // See issue crbug.com/405338
80 #define V8_DEFAULT_STACK_SIZE_KB 864 80 #define V8_DEFAULT_STACK_SIZE_KB 864
81 #else 81 #else
82 // Slightly less than 1MB, since Windows' default stack size for 82 // Slightly less than 1MB, since Windows' default stack size for
83 // the main execution thread is 1MB for both 32 and 64-bit. 83 // the main execution thread is 1MB for both 32 and 64-bit.
84 #define V8_DEFAULT_STACK_SIZE_KB 984 84 #define V8_DEFAULT_STACK_SIZE_KB 984
85 #endif 85 #endif
86 86
87 87
88 // Determine whether double field unboxing feature is enabled.
89 #if (V8_TARGET_ARCH_X64 || V8_TARGET_ARCH_ARM64)
90 #define V8_DOUBLE_FIELDS_UNBOXING 0
Hannes Payer (out of office) 2014/11/06 12:29:46 wanna turn it on?
Igor Sheludko 2014/11/07 08:03:52 Yes, but in next CL. And maybe even in next Canary
91 #else
92 #define V8_DOUBLE_FIELDS_UNBOXING 0
93 #endif
94
88 // Support for alternative bool type. This is only enabled if the code is 95 // Support for alternative bool type. This is only enabled if the code is
89 // compiled with USE_MYBOOL defined. This catches some nasty type bugs. 96 // compiled with USE_MYBOOL defined. This catches some nasty type bugs.
90 // For instance, 'bool b = "false";' results in b == true! This is a hidden 97 // For instance, 'bool b = "false";' results in b == true! This is a hidden
91 // source of bugs. 98 // source of bugs.
92 // However, redefining the bool type does have some negative impact on some 99 // However, redefining the bool type does have some negative impact on some
93 // platforms. It gives rise to compiler warnings (i.e. with 100 // platforms. It gives rise to compiler warnings (i.e. with
94 // MSVC) in the API header files when mixing code that uses the standard 101 // MSVC) in the API header files when mixing code that uses the standard
95 // bool with code that uses the redefined version. 102 // bool with code that uses the redefined version.
96 // This does not actually belong in the platform code, but needs to be 103 // This does not actually belong in the platform code, but needs to be
97 // defined here because the platform code uses bool, and platform.h is 104 // defined here because the platform code uses bool, and platform.h is
(...skipping 707 matching lines...) Expand 10 before | Expand all | Expand 10 after
805 812
806 inline bool IsConciseMethod(FunctionKind kind) { 813 inline bool IsConciseMethod(FunctionKind kind) {
807 DCHECK(IsValidFunctionKind(kind)); 814 DCHECK(IsValidFunctionKind(kind));
808 return kind & FunctionKind::kConciseMethod; 815 return kind & FunctionKind::kConciseMethod;
809 } 816 }
810 } } // namespace v8::internal 817 } } // namespace v8::internal
811 818
812 namespace i = v8::internal; 819 namespace i = v8::internal;
813 820
814 #endif // V8_GLOBALS_H_ 821 #endif // V8_GLOBALS_H_
OLDNEW
« no previous file with comments | « src/flag-definitions.h ('k') | src/heap/heap.cc » ('j') | src/heap/objects-visiting.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698