In-object double fields unboxing (for 64-bit only).

src/x64/stub-cache-x64.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/v8.h"
 
 #if V8_TARGET_ARCH_X64
 
 #include "src/arguments.h"
 #include "src/codegen.h"
@@ skipping 470 matching lines @@
         it.Advance();
         if (it.Done()) {
           __ j(not_equal, miss_label);
           break;
         }
         __ j(equal, &do_store, Label::kNear);
       }
       __ bind(&do_store);
     }
   } else if (representation.IsDouble()) {
+    FieldIndex index = FieldIndex::ForDescriptor(*transition, descriptor);
+
     Label do_store, heap_number;
-    __ AllocateHeapNumber(storage_reg, scratch1, slow, MUTABLE);
+    if (!FLAG_unbox_double_fields || !index.is_inobject()) {
+      __ AllocateHeapNumber(storage_reg, scratch1, slow, MUTABLE);
+    }
 
     __ JumpIfNotSmi(value_reg, &heap_number);
     __ SmiToInteger32(scratch1, value_reg);
     __ Cvtlsi2sd(xmm0, scratch1);
     __ jmp(&do_store);
 
     __ bind(&heap_number);
     __ CheckMap(value_reg, masm->isolate()->factory()->heap_number_map(),
                 miss_label, DONT_DO_SMI_CHECK);
     __ movsd(xmm0, FieldOperand(value_reg, HeapNumber::kValueOffset));
 
     __ bind(&do_store);
-    __ movsd(FieldOperand(storage_reg, HeapNumber::kValueOffset), xmm0);
+    if (!FLAG_unbox_double_fields || !index.is_inobject()) {
+      __ movsd(FieldOperand(storage_reg, HeapNumber::kValueOffset), xmm0);
+    }
   }
 
   // Stub never generated for non-global objects that require access
   // checks.
   ASSERT(object->IsJSGlobalProxy() || !object->IsAccessCheckNeeded());
 
   // Perform map transition for the receiver if necessary.
   if (details.type() == FIELD &&
       object->map()->unused_property_fields() == 0) {
     // The properties must be extended before we can store the value.
@@ skipping 23 matching lines @@
                       kDontSaveFPRegs,
                       OMIT_REMEMBERED_SET,
                       OMIT_SMI_CHECK);
 
   if (details.type() == CONSTANT) {
     ASSERT(value_reg.is(rax));
     __ ret(0);
     return;
   }
 
-  int index = transition->instance_descriptors()->GetFieldIndex(
-      transition->LastAdded());
-
-  // Adjust for the number of properties stored in the object. Even in the
-  // face of a transition we can use the old map here because the size of the
-  // object and the number of in-object properties is not going to change.
-  index -= object->map()->inobject_properties();
+  FieldIndex index = FieldIndex::ForDescriptor(*transition, descriptor);

[Toon Verwaest, 2014/07/29 15:02:09]

Nice cleanup. What about porting this to other platforms as well?

[Igor Sheludko, 2014/10/30 14:23:44]

Done.

 
   // TODO(verwaest): Share this code as a code stub.
   SmiCheck smi_check = representation.IsTagged()
       ? INLINE_SMI_CHECK : OMIT_SMI_CHECK;
-  if (index < 0) {
+  if (index.is_inobject()) {
     // Set the property straight into the object.
-    int offset = object->map()->instance_size() + (index * kPointerSize);
-    if (representation.IsDouble()) {
-      __ movp(FieldOperand(receiver_reg, offset), storage_reg);
+    if (FLAG_unbox_double_fields && representation.IsDouble()) {
+      __ movsd(FieldOperand(receiver_reg, index.offset()), xmm0);
+    } else if (representation.IsDouble()) {
+      __ movp(FieldOperand(receiver_reg, index.offset()), storage_reg);
     } else {
-      __ movp(FieldOperand(receiver_reg, offset), value_reg);
+      __ movp(FieldOperand(receiver_reg, index.offset()), value_reg);
     }
 
-    if (!representation.IsSmi()) {
+    if ((!FLAG_unbox_double_fields || !representation.IsDouble()) &&
+        !representation.IsSmi()) {
       // Update the write barrier for the array address.
       if (!representation.IsDouble()) {
         __ movp(storage_reg, value_reg);
       }
-      __ RecordWriteField(
-          receiver_reg, offset, storage_reg, scratch1, kDontSaveFPRegs,
-          EMIT_REMEMBERED_SET, smi_check);
+      __ RecordWriteField(receiver_reg, index.offset(), storage_reg, scratch1,
+                          kDontSaveFPRegs, EMIT_REMEMBERED_SET, smi_check);
     }
   } else {
     // Write to the properties array.
-    int offset = index * kPointerSize + FixedArray::kHeaderSize;
     // Get the properties array (optimistically).
     __ movp(scratch1, FieldOperand(receiver_reg, JSObject::kPropertiesOffset));
     if (representation.IsDouble()) {
-      __ movp(FieldOperand(scratch1, offset), storage_reg);
+      __ movp(FieldOperand(scratch1, index.offset()), storage_reg);
     } else {
-      __ movp(FieldOperand(scratch1, offset), value_reg);
+      __ movp(FieldOperand(scratch1, index.offset()), value_reg);
     }
 
     if (!representation.IsSmi()) {
       // Update the write barrier for the array address.
       if (!representation.IsDouble()) {
         __ movp(storage_reg, value_reg);
       }
-      __ RecordWriteField(
-          scratch1, offset, storage_reg, receiver_reg, kDontSaveFPRegs,
-          EMIT_REMEMBERED_SET, smi_check);
+      __ RecordWriteField(scratch1, index.offset(), storage_reg, receiver_reg,
+                          kDontSaveFPRegs, EMIT_REMEMBERED_SET, smi_check);
     }
   }
 
   // Return the value (register rax).
   ASSERT(value_reg.is(rax));
   __ ret(0);
 }
 
 
 // Both name_reg and receiver_reg are preserved on jumps to miss_label,
@@ skipping 28 matching lines @@
         it.Advance();
         if (it.Done()) {
           __ j(not_equal, miss_label);
           break;
         }
         __ j(equal, &do_store, Label::kNear);
       }
       __ bind(&do_store);
     }
   } else if (representation.IsDouble()) {
-    // Load the double storage.
-    if (index.is_inobject()) {
-      __ movp(scratch1, FieldOperand(receiver_reg, index.offset()));
-    } else {
-      __ movp(scratch1,
-              FieldOperand(receiver_reg, JSObject::kPropertiesOffset));
-      __ movp(scratch1, FieldOperand(scratch1, index.offset()));
-    }
-
-    // Store the value into the storage.
+    // Prepare value for storing.
     Label do_store, heap_number;
     __ JumpIfNotSmi(value_reg, &heap_number);
-    __ SmiToInteger32(scratch2, value_reg);
-    __ Cvtlsi2sd(xmm0, scratch2);
+    __ SmiToInteger32(scratch1, value_reg);
+    __ Cvtlsi2sd(xmm0, scratch1);
     __ jmp(&do_store);
 
     __ bind(&heap_number);
     __ CheckMap(value_reg, masm->isolate()->factory()->heap_number_map(),
                 miss_label, DONT_DO_SMI_CHECK);
     __ movsd(xmm0, FieldOperand(value_reg, HeapNumber::kValueOffset));
+
     __ bind(&do_store);
-    __ movsd(FieldOperand(scratch1, HeapNumber::kValueOffset), xmm0);
+    // Store it either to respective mutable box or directly to in-object field.
+    Operand operand = FieldOperand(scratch1, HeapNumber::kValueOffset);

[Toon Verwaest, 2014/07/29 15:02:09]

Arg this code is confusing. Can you please just set up Operand after loading
values into scratch1? e.g.:

Operand operand = FLAG_unbox_double_fields && index.is_inobject()
    ? FieldOperand(receiver_reg, index.offset()
    : FieldOperand(scratch1, HeapNumber::kValueOffset);

I know it doesn't really matter, but it's a bit confusing that you "load
something from scratch1", and only then set up "scratch1".

[Igor Sheludko, 2014/10/30 14:23:44]

Done.

+    if (index.is_inobject()) {
+      if (FLAG_unbox_double_fields) {
+        operand = FieldOperand(receiver_reg, index.offset());
+      } else {
+        __ movp(scratch1, FieldOperand(receiver_reg, index.offset()));
+      }
+    } else {
+      __ movp(scratch1,
+              FieldOperand(receiver_reg, JSObject::kPropertiesOffset));
+      __ movp(scratch1, FieldOperand(scratch1, index.offset()));
+    }
+    __ movsd(operand, xmm0);
     // Return the value (register rax).
     ASSERT(value_reg.is(rax));
     __ ret(0);
     return;
   }
 
   // TODO(verwaest): Share this code as a code stub.
   SmiCheck smi_check = representation.IsTagged()
       ? INLINE_SMI_CHECK : OMIT_SMI_CHECK;
   if (index.is_inobject()) {
@@ skipping 760 matching lines @@
   // -----------------------------------
   TailCallBuiltin(masm, Builtins::kKeyedLoadIC_Miss);
 }
 
 
 #undef __
 
 } }  // namespace v8::internal
 
 #endif  // V8_TARGET_ARCH_X64