In-object double fields unboxing (for 64-bit only).

src/objects-visiting.cc

 // Copyright 2011 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/v8.h"
 
 #include "src/ic-inl.h"
 #include "src/objects-visiting.h"
 
 namespace v8 {
 namespace internal {
 
 
 static inline bool IsShortcutCandidate(int type) {
   return ((type & kShortcutTypeMask) == kShortcutTypeTag);
 }
 
 
 StaticVisitorBase::VisitorId StaticVisitorBase::GetVisitorId(
-    int instance_type,
-    int instance_size) {
+    int instance_type, int instance_size, bool has_non_tagged_fields) {

[Toon Verwaest, 2014/07/29 15:02:09]

has_unboxed_fields?

[Igor Sheludko, 2014/10/30 14:23:44]

Done.

   if (instance_type < FIRST_NONSTRING_TYPE) {
     switch (instance_type & kStringRepresentationMask) {
       case kSeqStringTag:
         if ((instance_type & kStringEncodingMask) == kOneByteStringTag) {
           return kVisitSeqOneByteString;
         } else {
           return kVisitSeqTwoByteString;
         }
 
       case kConsStringTag:
         if (IsShortcutCandidate(instance_type)) {
           return kVisitShortcutCandidate;
         } else {
           return kVisitConsString;
         }
 
       case kSlicedStringTag:
         return kVisitSlicedString;
 
       case kExternalStringTag:
-        return GetVisitorIdForSize(kVisitDataObject,
-                                   kVisitDataObjectGeneric,
-                                   instance_size);
+        return GetVisitorIdForSize(kVisitDataObject, kVisitDataObjectGeneric,
+                                   instance_size, has_non_tagged_fields);
     }
     UNREACHABLE();
   }
 
   switch (instance_type) {
     case BYTE_ARRAY_TYPE:
       return kVisitByteArray;
 
     case FREE_SPACE_TYPE:
       return kVisitFreeSpace;
@@ skipping 16 matching lines @@
     case CODE_TYPE:
       return kVisitCode;
 
     case CELL_TYPE:
       return kVisitCell;
 
     case PROPERTY_CELL_TYPE:
       return kVisitPropertyCell;
 
     case JS_SET_TYPE:
-      return GetVisitorIdForSize(kVisitStruct,
-                                 kVisitStructGeneric,
-                                 JSSet::kSize);
+      return GetVisitorIdForSize(kVisitStruct, kVisitStructGeneric,
+                                 JSSet::kSize, has_non_tagged_fields);
 
     case JS_MAP_TYPE:
-      return GetVisitorIdForSize(kVisitStruct,
-                                 kVisitStructGeneric,
-                                 JSMap::kSize);
+      return GetVisitorIdForSize(kVisitStruct, kVisitStructGeneric,
+                                 JSMap::kSize, has_non_tagged_fields);
 
     case JS_WEAK_MAP_TYPE:
     case JS_WEAK_SET_TYPE:
       return kVisitJSWeakCollection;
 
     case JS_REGEXP_TYPE:
       return kVisitJSRegExp;
 
     case SHARED_FUNCTION_INFO_TYPE:
       return kVisitSharedFunctionInfo;
 
     case JS_PROXY_TYPE:
-      return GetVisitorIdForSize(kVisitStruct,
-                                 kVisitStructGeneric,
-                                 JSProxy::kSize);
+      return GetVisitorIdForSize(kVisitStruct, kVisitStructGeneric,
+                                 JSProxy::kSize, has_non_tagged_fields);
 
     case JS_FUNCTION_PROXY_TYPE:
-      return GetVisitorIdForSize(kVisitStruct,
-                                 kVisitStructGeneric,
-                                 JSFunctionProxy::kSize);
+      return GetVisitorIdForSize(kVisitStruct, kVisitStructGeneric,
+                                 JSFunctionProxy::kSize, has_non_tagged_fields);
 
     case FOREIGN_TYPE:
-      return GetVisitorIdForSize(kVisitDataObject,
-                                 kVisitDataObjectGeneric,
-                                 Foreign::kSize);
+      return GetVisitorIdForSize(kVisitDataObject, kVisitDataObjectGeneric,
+                                 Foreign::kSize, has_non_tagged_fields);
 
     case SYMBOL_TYPE:
       return kVisitSymbol;
 
     case FILLER_TYPE:
       return kVisitDataObjectGeneric;
 
     case JS_ARRAY_BUFFER_TYPE:
       return kVisitJSArrayBuffer;
 
     case JS_TYPED_ARRAY_TYPE:
       return kVisitJSTypedArray;
 
     case JS_DATA_VIEW_TYPE:
       return kVisitJSDataView;
 
     case JS_OBJECT_TYPE:
     case JS_CONTEXT_EXTENSION_OBJECT_TYPE:
     case JS_GENERATOR_OBJECT_TYPE:
     case JS_MODULE_TYPE:
     case JS_VALUE_TYPE:
     case JS_DATE_TYPE:
     case JS_ARRAY_TYPE:
     case JS_GLOBAL_PROXY_TYPE:
     case JS_GLOBAL_OBJECT_TYPE:
     case JS_BUILTINS_OBJECT_TYPE:
     case JS_MESSAGE_OBJECT_TYPE:
     case JS_SET_ITERATOR_TYPE:
     case JS_MAP_ITERATOR_TYPE:
-      return GetVisitorIdForSize(kVisitJSObject,
-                                 kVisitJSObjectGeneric,
-                                 instance_size);
+      return GetVisitorIdForSize(kVisitJSObject, kVisitJSObjectGeneric,
+                                 instance_size, has_non_tagged_fields);
 
     case JS_FUNCTION_TYPE:
       return kVisitJSFunction;
 
     case HEAP_NUMBER_TYPE:
     case MUTABLE_HEAP_NUMBER_TYPE:
 #define EXTERNAL_ARRAY_CASE(Type, type, TYPE, ctype, size)                     \
     case EXTERNAL_##TYPE##_ARRAY_TYPE:
 
     TYPED_ARRAYS(EXTERNAL_ARRAY_CASE)
-      return GetVisitorIdForSize(kVisitDataObject,
-                                 kVisitDataObjectGeneric,
-                                 instance_size);
+    return GetVisitorIdForSize(kVisitDataObject, kVisitDataObjectGeneric,
+                               instance_size, has_non_tagged_fields);
 #undef EXTERNAL_ARRAY_CASE
 
     case FIXED_UINT8_ARRAY_TYPE:
     case FIXED_INT8_ARRAY_TYPE:
     case FIXED_UINT16_ARRAY_TYPE:
     case FIXED_INT16_ARRAY_TYPE:
     case FIXED_UINT32_ARRAY_TYPE:
     case FIXED_INT32_ARRAY_TYPE:
     case FIXED_FLOAT32_ARRAY_TYPE:
     case FIXED_UINT8_CLAMPED_ARRAY_TYPE:
       return kVisitFixedTypedArray;
 
     case FIXED_FLOAT64_ARRAY_TYPE:
       return kVisitFixedFloat64Array;
 
 #define MAKE_STRUCT_CASE(NAME, Name, name) \
         case NAME##_TYPE:
       STRUCT_LIST(MAKE_STRUCT_CASE)
 #undef MAKE_STRUCT_CASE
           if (instance_type == ALLOCATION_SITE_TYPE) {
             return kVisitAllocationSite;
           }
 
-          return GetVisitorIdForSize(kVisitStruct,
-                                     kVisitStructGeneric,
-                                     instance_size);
+          return GetVisitorIdForSize(kVisitStruct, kVisitStructGeneric,
+                                     instance_size, has_non_tagged_fields);
 
     default:
       UNREACHABLE();
       return kVisitorIdCount;
   }
 }
 
 
 // We don't record weak slots during marking or scavenges. Instead we do it
 // once when we complete mark-compact cycle.  Note that write barrier has no
@@ skipping 256 matching lines @@
 
 
 template Object* VisitWeakList<JSArrayBuffer>(
     Heap* heap, Object* list, WeakObjectRetainer* retainer);
 
 
 template Object* VisitWeakList<AllocationSite>(
     Heap* heap, Object* list, WeakObjectRetainer* retainer);
 
 } }  // namespace v8::internal