In-object double fields unboxing (for 64-bit only).

src/objects-debug.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/v8.h"
 
 #include "src/disasm.h"
 #include "src/disassembler.h"
 #include "src/jsregexp.h"
 #include "src/macro-assembler.h"
@@ skipping 245 matching lines @@
 
   if (HasFastProperties()) {
     CHECK_EQ(map()->unused_property_fields(),
              (map()->inobject_properties() + properties()->length() -
               map()->NextFreePropertyIndex()));
     DescriptorArray* descriptors = map()->instance_descriptors();
     for (int i = 0; i < map()->NumberOfOwnDescriptors(); i++) {
       if (descriptors->GetDetails(i).type() == FIELD) {
         Representation r = descriptors->GetDetails(i).representation();
         FieldIndex index = FieldIndex::ForDescriptor(map(), i);
+        if (map()->IsUnboxedDoubleField(index)) continue;

[Toon Verwaest, 2014/07/29 15:02:08]

Assert that r.IsDouble()

[Igor Sheludko, 2014/10/30 14:23:43]

Done.

         Object* value = RawFastPropertyAt(index);
         if (r.IsDouble()) ASSERT(value->IsMutableHeapNumber());
         if (value->IsUninitialized()) continue;
         if (r.IsSmi()) ASSERT(value->IsSmi());
         if (r.IsHeapObject()) ASSERT(value->IsHeapObject());
         HeapType* field_type = descriptors->GetFieldType(i);
         if (r.IsNone()) {
           CHECK(field_type->Is(HeapType::None()));
         } else if (!HeapType::Any()->Is(field_type)) {
           CHECK(!field_type->NowStable() || field_type->NowContains(value));
@@ skipping 21 matching lines @@
   CHECK(instance_size() == kVariableSizeSentinel ||
          (kPointerSize <= instance_size() &&
           instance_size() < heap->Capacity()));
   VerifyHeapPointer(prototype());
   VerifyHeapPointer(instance_descriptors());
   SLOW_ASSERT(instance_descriptors()->IsSortedNoDuplicates());
   if (HasTransitionArray()) {
     SLOW_ASSERT(transitions()->IsSortedNoDuplicates());
     SLOW_ASSERT(transitions()->IsConsistentWithBackPointers(this));
   }
+  ASSERT(!FLAG_unbox_double_fields ||

[Toon Verwaest, 2014/07/29 15:02:08]

SLOW_ASSERT?

[Igor Sheludko, 2014/10/30 14:23:43]

Done.

+         layout_descriptor()->IsConsistentWithMap(this));
 }
 
 
 void Map::SharedMapVerify() {
   MapVerify();
   CHECK(is_shared());
   CHECK(instance_descriptors()->IsEmpty());
   CHECK_EQ(0, pre_allocated_property_fields());
   CHECK_EQ(0, unused_property_fields());
-  CHECK_EQ(StaticVisitorBase::GetVisitorId(instance_type(), instance_size()),
-      visitor_id());
+  CHECK_EQ(StaticVisitorBase::GetVisitorId(this), visitor_id());
 }
 
 
 void Map::VerifyOmittedMapChecks() {
   if (!FLAG_omit_map_checks_for_leaf_maps) return;
   if (!is_stable() ||
       is_deprecated() ||
       HasTransitionArray() ||
       is_dictionary_map()) {
     CHECK_EQ(0, dependent_code()->number_of_entries(
@@ skipping 822 matching lines @@
       OFStream os(stdout);
       PrintDescriptors(os);
       return false;
     }
     current = hash;
   }
   return true;
 }
 
 
+bool LayoutDescriptor::IsConsistentWithMap(Map* map) {
+  DescriptorArray* descriptors = map->instance_descriptors();
+  int nof_descriptors = map->NumberOfOwnDescriptors();
+  for (int i = 0; i < nof_descriptors; i++) {
+    PropertyDetails details = descriptors->GetDetails(i);
+    if (details.type() == FIELD) {
+      FieldIndex field_index = FieldIndex::ForDescriptor(map, i);
+      if (!field_index.is_inobject()) continue;
+      bool tagged_expected =
+          !FLAG_unbox_double_fields || !details.representation().IsDouble();
+      for (int bit = 0; bit < details.field_width_in_words(); bit++) {
+        bool tagged_actual = IsTagged(details.field_index() + bit);
+        ASSERT_EQ(tagged_expected, tagged_actual);
+        if (tagged_actual != tagged_expected) return false;
+      }
+    }
+  }
+  return true;
+}
+
+
 bool TransitionArray::IsSortedNoDuplicates(int valid_entries) {
   ASSERT(valid_entries == -1);
   Name* current_key = NULL;
   uint32_t current = 0;
   for (int i = 0; i < number_of_transitions(); i++) {
     Name* key = GetSortedKey(i);
     if (key == current_key) {
       OFStream os(stdout);
       PrintTransitions(os);
       return false;
@@ skipping 20 matching lines @@
   for (int i = 0; i < number_of_transitions(); ++i) {
     if (!CheckOneBackPointer(current_map, GetTarget(i))) return false;
   }
   return true;
 }
 
 
 #endif  // DEBUG
 
 } }  // namespace v8::internal