Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 391683002: Include symbol properties in Object.{create,defineProperties} (Closed)

Created:
6 years, 5 months ago by rossberg
Modified:
6 years, 5 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Include symbol properties in Object.{create,defineProperties} R=mstarzinger@chromium.org BUG=v8:3440 LOG=Y Committed: https://code.google.com/p/v8/source/detail?r=22370

Patch Set 1 #

Total comments: 3

Patch Set 2 : Removed DebugPrint #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -3 lines) Patch
M src/v8natives.js View 1 1 chunk +11 lines, -3 lines 0 comments Download
M test/mjsunit/es6/symbols.js View 1 chunk +28 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
rossberg
6 years, 5 months ago (2014-07-14 10:47:26 UTC) #1
Michael Starzinger
LGTM with nits. https://codereview.chromium.org/391683002/diff/1/src/v8natives.js File src/v8natives.js (right): https://codereview.chromium.org/391683002/diff/1/src/v8natives.js#newcode1185 src/v8natives.js:1185: %DebugPrint(symbol); nit: This looks like a ...
6 years, 5 months ago (2014-07-14 10:56:01 UTC) #2
rossberg
On 2014/07/14 10:56:01, Michael Starzinger wrote: > LGTM with nits. > > https://codereview.chromium.org/391683002/diff/1/src/v8natives.js > File ...
6 years, 5 months ago (2014-07-14 10:57:12 UTC) #3
rossberg
6 years, 5 months ago (2014-07-14 10:59:36 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r22370 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698