Chromium Code Reviews
Help | Chromium Project | Sign in
(30)

Issue 39163: Make JavaScript alerts reflect the URL of the frame they came from, not the... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 12 months ago by brettw (plz ping after 24h)
Modified:
5 years, 9 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Make JavaScript alerts reflect the URL of the frame they came from, not the enclosing frame. BUG=1686837 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=11002

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -53 lines) Patch
M chrome/browser/extensions/extension_view.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/extension_view.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/extension_view_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/js_before_unload_handler.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/js_before_unload_handler_win.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/js_before_unload_handler_win.cc View 2 chunks +11 lines, -8 lines 0 comments Download
M chrome/browser/jsmessage_box_handler.h View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/jsmessage_box_handler_win.h View 3 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/jsmessage_box_handler_win.cc View 4 chunks +13 lines, -14 lines 0 comments Download
M chrome/browser/renderer_host/render_view_host.h View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/renderer_host/render_view_host.cc View 1 chunk +6 lines, -3 lines 0 comments Download
M chrome/browser/renderer_host/render_view_host_delegate.h View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/tab_contents/web_contents.h View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/common/render_messages_internal.h View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/renderer/render_view.h View 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/renderer/render_view.cc View 2 chunks +10 lines, -6 lines 0 comments Download
M webkit/glue/chrome_client_impl.cc View 1 4 chunks +7 lines, -6 lines 0 comments Download
M webkit/glue/webframe.h View 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/glue/webview_delegate.h View 1 4 chunks +6 lines, -5 lines 0 comments Download
Trybot results:
Commit queue not available (can’t edit this change).

Messages

Total messages: 2 (0 generated)
brettw (plz ping after 24h)
7 years, 12 months ago (2009-03-04 23:01:13 UTC) #1
darin (slow to review)
7 years, 12 months ago (2009-03-04 23:08:52 UTC) #2
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f8e48bd