Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 391623002: [SyncFS] Build indexes from FileTracker entries on disk. (Closed)

Created:
6 years, 5 months ago by peria
Modified:
6 years, 5 months ago
Reviewers:
nhiroki, tzik
CC:
chromium-reviews, kinuko+fileapi, nhiroki, tzik
Project:
chromium
Visibility:
Public.

Description

[SyncFS] Build indexes from FileTracker entries on disk. It is assumed that no indexes exist before. BUG=347425 TEST=./unit_tests --gtest_filter="MetadataDatabaseIndexOnDiskTest.*" Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283759

Patch Set 1 : #

Total comments: 4

Patch Set 2 : Rebase and work for a nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -1 line) Patch
M chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk.cc View 1 1 chunk +21 lines, -0 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk_unittest.cc View 1 2 chunks +30 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
peria
Please take a look
6 years, 5 months ago (2014-07-16 04:50:40 UTC) #1
tzik
lgtm
6 years, 5 months ago (2014-07-16 05:23:24 UTC) #2
nhiroki
lgtm with nits https://codereview.chromium.org/391623002/diff/20001/chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk_unittest.cc File chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk_unittest.cc (right): https://codereview.chromium.org/391623002/diff/20001/chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk_unittest.cc#newcode193 chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk_unittest.cc:193: EXPECT_EQ(0U, tracker_ids.size()); nit: .empty() https://codereview.chromium.org/391623002/diff/20001/chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk_unittest.cc#newcode196 chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk_unittest.cc:196: ...
6 years, 5 months ago (2014-07-16 06:49:12 UTC) #3
peria
https://codereview.chromium.org/391623002/diff/20001/chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk_unittest.cc File chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk_unittest.cc (right): https://codereview.chromium.org/391623002/diff/20001/chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk_unittest.cc#newcode193 chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk_unittest.cc:193: EXPECT_EQ(0U, tracker_ids.size()); On 2014/07/16 06:49:12, nhiroki wrote: > nit: ...
6 years, 5 months ago (2014-07-16 06:54:50 UTC) #4
peria
The CQ bit was checked by peria@chromium.org
6 years, 5 months ago (2014-07-17 08:15:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/peria@chromium.org/391623002/40001
6 years, 5 months ago (2014-07-17 08:16:09 UTC) #6
commit-bot: I haz the power
6 years, 5 months ago (2014-07-17 11:57:44 UTC) #7
Message was sent while issue was closed. 
Change committed as 283759

Powered by Google App Engine
This is Rietveld 408576698